Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1801142: Vmi dashboard tests #4265

Merged
merged 5 commits into from Feb 14, 2020
Merged

Bug 1801142: Vmi dashboard tests #4265

merged 5 commits into from Feb 14, 2020

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Feb 10, 2020 •
edited

depend on #4209

A test to check VMI dashboard page.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/kubevirt Related to kubevirt-plugin labels Feb 10, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2020
@yaacov
Copy link
Member Author

yaacov commented Feb 10, 2020

@rhrazdil please review commit add dashboard tests , ( the rest is from #4209 )

@yaacov yaacov changed the title [WIP] Vmi dashboard tests [Bug 1801142][WIP] Vmi dashboard tests Feb 10, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2020
@yaacov yaacov changed the title [Bug 1801142][WIP] Vmi dashboard tests [WIP] [Bug 1801142][Vmi dashboard tests Feb 10, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2020
@yaacov yaacov changed the title [WIP] [Bug 1801142][Vmi dashboard tests [WIP] [Bug 1801142]Vmi dashboard tests Feb 10, 2020
@yaacov yaacov force-pushed the vmi-dashboard-tests branch 2 times, most recently from fe2bb0c to be48fe8 Compare February 11, 2020 09:57
@yaacov
Copy link
Member Author

yaacov commented Feb 11, 2020

/test analyze

@yaacov
Copy link
Member Author

yaacov commented Feb 11, 2020

/test e2e-gcp-console

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 12, 2020
rhrazdil
rhrazdil suggested changes Feb 12, 2020
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/tests/vmi.overview.scenario.ts Outdated
import { TAB, VM_STATUS, NOT_AVAILABLE } from './utils/consts';
import { NodePortService } from './utils/types';

describe('Test VM overview', () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VMI

frontend/packages/kubevirt-plugin/integration-tests/tests/vmi.overview.scenario.ts Outdated
).not.toEqual(NOT_AVAILABLE);
});

it('Check vm services', async () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VMI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !
fixed 👍

@yaacov
Copy link
Member Author

yaacov commented Feb 12, 2020

/test frontend

@yaacov yaacov changed the title [WIP] [Bug 1801142]Vmi dashboard tests Bug 1801142: Vmi dashboard tests Feb 12, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2020
@openshift-ci-robot
Copy link
Contributor

@yaacov: This pull request references Bugzilla bug 1801142, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1801142: Vmi dashboard tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 12, 2020
@openshift-ci-robot
Copy link
Contributor

@yaacov: This pull request references Bugzilla bug 1801142, which is valid.

In response to this:

Bug 1801142: Vmi dashboard tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 12, 2020
@yaacov
Copy link
Member Author

yaacov commented Feb 12, 2020

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Feb 13, 2020

/test e2e-gcp-console
/test images

rhrazdil
rhrazdil reviewed Feb 13, 2020
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/tests/models/virtualMachine.ts Outdated
import { KubevirtDetailView } from './kubevirtDetailView';
import { ImportWizard } from './importWizard';

const confirmDialogActions = [
VM_ACTION.Clone,
VM_ACTION.Start,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start is not to be confirmed anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yaacov
Copy link
Member Author

yaacov commented Feb 13, 2020

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Feb 13, 2020

/test analyze
/test e2e-gcp-console

rhrazdil
rhrazdil reviewed Feb 13, 2020
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/tests/vmi.overview.scenario.ts Outdated
import { TAB, VM_STATUS, NOT_AVAILABLE } from './utils/consts';
import { NodePortService } from './utils/types';

describe('Test VMI overview', () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably would be better to change overview to Details, so that it's not confusing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dnoe

p.s.
do we need to rename the files ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaacov I think it would be better to align file names with the current naming, if you don't mind :)

frontend/packages/kubevirt-plugin/integration-tests/tests/vmi.overview.scenario.ts Outdated
await isLoaded();
});

it('Check VMI details in overview', async () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Check VMI data in Details'?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@yaacov
Copy link
Member Author

yaacov commented Feb 14, 2020

/test e2e-gcp-console

@rhrazdil
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhrazdil, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yaacov
Copy link
Member Author

yaacov commented Feb 14, 2020

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 94ad5e4 into openshift:master Feb 14, 2020
@openshift-ci-robot
Copy link
Contributor

@yaacov: All pull requests linked via external trackers have merged. Bugzilla bug 1801142 has been moved to the MODIFIED state.

In response to this:

Bug 1801142: Vmi dashboard tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhrazdil rhrazdil rhrazdil requested changes

@pcbailey pcbailey Awaiting requested review from pcbailey

@vojtechszocs vojtechszocs Awaiting requested review from vojtechszocs

Assignees

@rhrazdil rhrazdil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yaacov @openshift-ci-robot @rhrazdil @openshift-bot @spadgett @openshift-merge-robot