Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1801278: Restructure the devconsole navigation menu #4269

Merged
merged 1 commit into from Feb 12, 2020
Merged

Bug 1801278: Restructure the devconsole navigation menu #4269

merged 1 commit into from Feb 12, 2020

Conversation

karthikjeeyar
Copy link
Contributor

@karthikjeeyar karthikjeeyar commented Feb 10, 2020 •
edited

Restructure and rename the navigation menu

  1. Renamed Advanced section to More
  2. Moved Helm Releases menu item into the More section and renamed it to Helm

AwesomeScreenshot-2020-2-10-1581344117892

Fixes: https://issues.redhat.com/browse/ODC-2967

cc: @christianvogt @serenamarie125

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 10, 2020
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Feb 10, 2020
@karthikjeeyar
Copy link
Contributor Author

/retitle Bug 1801278: Restructure the devconsole navigation menu

@openshift-ci-robot openshift-ci-robot changed the title Restructure the devconsole navigation menu Bug 1801278: Restructure the devconsole navigation menu Feb 10, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 10, 2020
@openshift-ci-robot
Copy link
Contributor

@karthikjeeyar: This pull request references Bugzilla bug 1801278, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1801278: Restructure the devconsole navigation menu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karthikjeeyar
Copy link
Contributor Author

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 10, 2020
@openshift-ci-robot
Copy link
Contributor

@karthikjeeyar: This pull request references Bugzilla bug 1801278, which is valid.

In response to this:

Bug 1801278: Restructure the devconsole navigation menu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sahil143
sahil143 reviewed Feb 10, 2020
View reviewed changes
Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

verified changes locally

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2020
serenamarie125
serenamarie125 approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented per design request. Thanks @karthikjeeyar !

@christianvogt
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, karthikjeeyar, sahil143, serenamarie125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2020
@openshift-merge-robot openshift-merge-robot merged commit b05e60c into openshift:master Feb 12, 2020
@openshift-ci-robot
Copy link
Contributor

@karthikjeeyar: All pull requests linked via external trackers have merged. Bugzilla bug 1801278 has been moved to the MODIFIED state.

In response to this:

Bug 1801278: Restructure the devconsole navigation menu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahil143 sahil143 sahil143 left review comments

@serenamarie125 serenamarie125 serenamarie125 approved these changes

@christianvogt christianvogt Awaiting requested review from christianvogt

@debsmita1 debsmita1 Awaiting requested review from debsmita1

Assignees

@sahil143 sahil143

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@karthikjeeyar @openshift-ci-robot @christianvogt @sahil143 @serenamarie125 @spadgett @openshift-merge-robot