Bug 1801447: Fix for invalid edges, do not allow connection to knative revisions #4276
Conversation
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@jeff-phillips-18: This pull request references Bugzilla bug 1801447, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/M
|
@jeff-phillips-18 are we disallowing both Knative services & Revisions? |
|
/retest |
| // create links from data, only include those which have a valid source and target | ||
| const allNodes = [...nodes, ...groupNodes]; | ||
| const edges = dataModel.graph.edges | ||
| .filter((d) => { | ||
| return allNodes.find((n) => n.id === d.source) && allNodes.find((n) => n.id === d.target); | ||
| }) |
There was a problem hiding this comment.
In what situation do we have edges without valid source or target?
There was a problem hiding this comment.
This occurred when we allowed (mistakenly) connections to knative revisions or for a node to itself. While those situations have been taken care of, this change safe guards against other potential similar situations that could occur.
|
@serenamarie125 Yes, there was no current support for connection to a knative service and we do not want connections to revisions. If we want to add support for knative services as visual connector targets, we could add that . |
|
No need, just asking! Thanks Jeff |
|
/kind bug |
openshift-ci-robot
added
the
kind/bug
|
@jeff-phillips-18: This pull request references Bugzilla bug 1801447, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jeff-phillips-18: All pull requests linked via external trackers have merged. Bugzilla bug 1801447 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-3014
Analysis / Root cause:
Connections from non-knative workloads to knative objects resulted in edges with invalid targets.
We should no be allowing visual connectors to knative revisions.
Solution Description:
Check the edges for valid source and target. Remove any edges that have and invalid source or target. Do not allow creation of connectors to knative revisions.
Browser conformance:
cc @openshift/team-devconsole-ux @serenamarie125