Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1808865: Independent mode bug fixes #4279

Merged
merged 1 commit into from Feb 25, 2020
Merged

Bug 1808865: Independent mode bug fixes #4279

merged 1 commit into from Feb 25, 2020

Conversation

bipuladh
Copy link
Contributor

  • Changes field name from 'Namespace' to 'Cluster Name'
  • Changes the GET request sent for secret creation

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/ceph Related to ceph-storage-plugin labels Feb 11, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2020
afreen23
afreen23 reviewed Feb 24, 2020
View reviewed changes
Copy link
Contributor

@afreen23 afreen23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changes field name from 'Namespace' to 'Cluster Name'
  • Changes the GET request sent for secret creation

Can you mention why these changes are required ?

frontend/packages/ceph-storage-plugin/src/components/ocs-install/ocs-install.scss
@@ -25,3 +25,7 @@
font-weight: var(--pf-global--FontWeight--bold);
font-size: var(--pf-global--FontSize--md);
}

.ceph-install-select-mode {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets stick to the convention.

Suggested change
.ceph-install-select-mode {
.ceph-ocs-install-select-mode {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@bipuladh
Copy link
Contributor Author

@afreen23
Namespace field was incorrect, we are not interested in the ns of the converged cluster. @anmolsachan and I hence decided to move forward with this change.
Similarly, the GET request needs changes because we were adding a field to the secret which was not being consumed by OCS. Please have a look at Independent-Mode docs for further details. These are available at the OCS-Independent Mode channel.

@afreen23
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, bipuladh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5b9fb86 into openshift:master Feb 25, 2020
@openshift-ci-robot
Copy link
Contributor

@bipuladh: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console feb2c48 link /test e2e-gcp-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett spadgett added this to the v4.5 milestone Feb 28, 2020
@bipuladh bipuladh changed the title Independent mode bug fixes Bug 1808865: Independent mode bug fixes Mar 1, 2020
@openshift-ci-robot
Copy link
Contributor

@bipuladh: All pull requests linked via external trackers have merged. Bugzilla bug 1808865 has been moved to the MODIFIED state.

In response to this:

Bug 1808865: Independent mode bug fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bipuladh
Copy link
Contributor Author

bipuladh commented Mar 1, 2020

/cherrypick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 1, 2020
Merged
@openshift-cherrypick-robot
Copy link

@bipuladh: new pull request created: #4572

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afreen23 afreen23 afreen23 left review comments

@rawagner rawagner Awaiting requested review from rawagner

@shyRozen shyRozen Awaiting requested review from shyRozen

Assignees

@afreen23 afreen23

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bipuladh @afreen23 @openshift-ci-robot @openshift-bot @openshift-cherrypick-robot @spadgett @openshift-merge-robot