Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1802114: Add sort function for machine phase. #4292

Merged
merged 1 commit into from Feb 15, 2020
Merged

Bug 1802114: Add sort function for machine phase. #4292

merged 1 commit into from Feb 15, 2020

Conversation

rawagner
Copy link
Contributor

Use pf classes form columns.

@openshift-ci-robot
Copy link
Contributor

@rawagner: This pull request references Bugzilla bug 1802114, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1802114: Add sort function for machine phase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2020
@rawagner rawagner mentioned this pull request Feb 12, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2020
@rawagner
Copy link
Contributor Author

/assign @spadgett

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Feb 12, 2020
spadgett
spadgett reviewed Feb 12, 2020
View reviewed changes
frontend/public/components/machine.tsx Outdated
@@ -94,7 +94,7 @@ const MachineTableHeader = () => {
};
MachineTableHeader.displayName = 'MachineTableHeader';

const getMachinePhase = (obj: MachineKind) => {
export const getMachinePhase = (obj: MachineKind) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move this to a separate module, otherwise the machine pages will be bundled with all tables. Probably not a huge difference in this case, but it's a better pattern.

@benjaminapetersen
Copy link
Contributor

/assign @benjaminapetersen

Since @spadgett is on PTO rest of week.
Can tag after that one comment fixed!

@rawagner
Add sort function for machine phase.
a45886b 
Use pf classes form columns.
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/shared Related to console-shared and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 13, 2020
@rawagner
Copy link
Contributor Author

/assign @benjaminapetersen

Moved the getMachinePhase to console-shared selectors

@rawagner
Copy link
Contributor Author

/retest

spadgett
spadgett approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks 👍

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawagner, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f2830b9 into openshift:master Feb 15, 2020
@openshift-ci-robot
Copy link
Contributor

@rawagner: All pull requests linked via external trackers have merged. Bugzilla bug 1802114 has been moved to the MODIFIED state.

In response to this:

Bug 1802114: Add sort function for machine phase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@benjaminapetersen benjaminapetersen

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rawagner @openshift-ci-robot @benjaminapetersen @openshift-bot @spadgett @openshift-merge-robot