Bug 1794926: Search - Identify kind with more detail #4303
Conversation
|
@zherman0: This pull request references Bugzilla bug 1794926, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/retest |
| return ( | ||
| <span className="co-search-group__accordian-label"> | ||
| {labelPlural}{' '} | ||
| <span className="text-muted co-truncate show co-nowrap small"> |
There was a problem hiding this comment.
Rather than showing this for every resource, does it make sense to follow what we do in the dropdown and only show it if there is more than one instance of a resource?
I'm not sure truncation is the right solution here because you can lose the meaningful differentiator at mobile.
And in this instance, you can't even see all of the resource name (which is a separate, but related bug).
| @@ -23,6 +23,14 @@ | |||
| flex: 1 0 auto; | |||
| } | |||
|
|
|||
| .co-search-group__accordion-label { | |||
| display: flex; | |||
| align-items: center; | |||
There was a problem hiding this comment.
Nit: alphabetize declarations by property.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, zherman0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@zherman0: All pull requests linked via external trackers have merged. Bugzilla bug 1794926 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In order to better identify what resources are being shown, I have added the group and version to the title of each acordian section. The chips do not have this on the toolbar as we are concerned about space. We will discuss this further with UXD but this should help immensely for 4.4.
