Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1802458: add quarkus icon to topology #4306

Merged
merged 1 commit into from Feb 14, 2020

Conversation

sahil143
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/ODC-2708

Analysis / Root cause:
No icon available for quarkus runtime

Solution Description:
added quakus icon

Screen shots / Gifs for design review:
Screenshot from 2020-02-13 13-44-05

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 13, 2020
@openshift-ci-robot
Copy link
Contributor

@sahil143: This pull request references Bugzilla bug 1802458, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1802458: add quarkus icon to topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 13, 2020
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Feb 13, 2020
@sahil143
Copy link
Contributor Author

/cc @serenamarie125 @openshift/team-devconsole-ux

@sahil143
Copy link
Contributor Author

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 13, 2020
Copy link
Contributor

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @sahil143 !

Just to confirm, in order for this icon to appear, the associated Deployment/Deployment Config needs to have an environment variable app.openshift.io/runtime=quarkus ?

@sahil143
Copy link
Contributor Author

Just to confirm, in order for this icon to appear, the associated Deployment/Deployment Config needs to have an environment variable app.openshift.io/runtime=quarkus ?

@serenamarie125 For this icon to appear, Deployment/Deployment Config needs to have either app.openshift.io/runtime=quarkus or app.kubernetes.io/name=quarkus label.

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit d3eee70 into openshift:master Feb 14, 2020
@openshift-ci-robot
Copy link
Contributor

@sahil143: All pull requests linked via external trackers have merged. Bugzilla bug 1802458 has been moved to the MODIFIED state.

In response to this:

Bug 1802458: add quarkus icon to topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants