New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1803245: add missing vertx runtime icon #4324
Bug 1803245: add missing vertx runtime icon #4324
Conversation
@christianvogt: This pull request references Bugzilla bug 1803245, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for tweaking the sizes of the images.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, serenamarie125 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@christianvogt: All pull requests linked via external trackers have merged. Bugzilla bug 1803245 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1803245
https://issues.redhat.com/browse/ODC-2711
Analysis / Root cause:
Assigning label
app.openshift.io/runtime=vertx
to a workload had no affect on the icon in topology. Expected the vertx icon to be displayed.Solution Description:
Added new vertx svg icon.
Since this icon is very square, it looked out of place in the node as it nearly touched the edge of the pod ring. Therefore also reduced the size of the icons by 10% to give a bit of extra padding.
Screen shots / Gifs for design review:
@openshift/team-devconsole-ux
Screenshot shows other logos for comparison as well:
Browser conformance: