New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1803252: Add connector when adding a project through connector #4325
Conversation
/kind bug |
/retitle Bug 1803252: Add connector when adding a project through connector |
@vikram-raj: This pull request references Bugzilla bug 1803252, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -38,10 +39,10 @@ export const getAddPageUrl = ( | |||
throw new Error('Invalid Import option provided'); | |||
} | |||
if (hasApplication && appGroup) { | |||
params.append('application', encodeURIComponent(appGroup)); | |||
params.append(QUERY_PROPERTIES.APPLICATION, encodeURIComponent(appGroup)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URLSearchParams
already encodes. The problem is now we're double encoding. Remove all use of encodeURIComponent
and decodeURIComponent
when using URLSearchParams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed use of encodeURIComponent
and decodeURIComponent
.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@vikram-raj: All pull requests linked via external trackers have merged. Bugzilla bug 1803252 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-3042
Analysis / Root cause:
When creating an application through the Context menu with the connector from one node, the connector does not appear.
Solution Description:
Decode the contextualSource param before passing it to form.
Screen shots / Gifs for design review:
Browser conformance: