Bug 1803213: Update collapsed groups in topology to match designs #4326
Conversation
|
@jeff-phillips-18: This pull request references Bugzilla bug 1803213, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
| @@ -693,7 +693,7 @@ export const topologyModelFromDataModel = ( | |||
| data.groupResources = d.children && d.children.map((id) => dataModel.topology[id]); | |||
| return { | |||
| width: 300, | |||
| height: 100, | |||
| height: d.type === TYPE_KNATIVE_SERVICE ? 100 : 180, | |||
There was a problem hiding this comment.
We should look at making this height dynamic based on the number of different types we will have. Probably worth a separate issue.
Or we update topology to better support dynamic height nodes based on the rendering.
| @@ -44,7 +55,7 @@ const GroupNode: React.FC<GroupNodeProps> = ({ children, kind, title, typeIconCl | |||
| iconClass={typeIconClass} | |||
| /> | |||
| )} | |||
| <SvgResourceIcon ref={iconRef} x={TOP_MARGIN} y={LEFT_MARGIN} kind={kind} leftJustified /> | |||
| <SvgResourceIcon ref={iconRef} x={LEFT_MARGIN} y={TOP_MARGIN - 2} kind={kind} leftJustified /> | |||
There was a problem hiding this comment.
Who did that 0_o heh
| <text x={TEXT_MARGIN}>{kindObj ? kindObj.labelPlural : emptyKind}</text> | ||
| </g> | ||
|
|
||
| if (!resourceTypes.length) { |
There was a problem hiding this comment.
Hmmm... should we combine this condition into the return value as a nested ternary.
| height: 100%; | ||
| overflow-y: auto; | ||
|
|
||
| &__table { |
There was a problem hiding this comment.
Do we need to make sure to unstyle the tables for browser compatibility?
There was a problem hiding this comment.
nm I just saw you tested on the main browsers already.
| </div> | ||
| </foreignObject> | ||
| ); | ||
| // return <g className="odc-resource-kinds-info__resources">{resources}</g>; |
|
/approve |
openshift-ci-robot
added
the
approved
jeff-phillips-18
force-pushed
the
group-cards
branch
from
44dc0f6
to
6d8c8bd
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jeff-phillips-18: All pull requests linked via external trackers have merged. Bugzilla bug 1803213 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-2946
Analysis / Root cause:
Collapsed groups showed only text for kind and used only the resource kind string to determine the value.
Solution Description:
Update the collapsed group component to show badges for each resource kind, find the correct kind model based on the objects being shown.
** Sample Screen Shots **
Browser conformance:
cc @serenamarie125 @Veethika @openshift/team-devconsole-ux