Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1801847: Monitoring Dashboards: Fix bar chart labels and fix row panels #4330

Merged
merged 1 commit into from Feb 17, 2020
Merged

Bug 1801847: Monitoring Dashboards: Fix bar chart labels and fix row panels #4330

merged 1 commit into from Feb 17, 2020

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Feb 15, 2020

Add bar chart labels.

Also fix a bug with handling the row panel type, which prevented some
of the cluster-total dashboard charts from rendering.

screenshot

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 15, 2020
@openshift-ci-robot
Copy link
Contributor

@kyoto: This pull request references Bugzilla bug 1801847, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1801847: Monitoring Dashboards: Fix bar chart labels and fix row panels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 15, 2020
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring labels Feb 15, 2020
@kyoto
Monitoring Dashboards: Fix bar chart labels and fix row panels
cd319f1 
Add bar chart labels.

Also fix a bug with handling the `row` panel type, which prevented some
of the `cluster-total` dashboard charts from rendering.
@kyoto kyoto force-pushed the monitoring-dashboards-fix-bar-chart-labels branch from 3cb069a to cd319f1 Compare February 15, 2020 14:32
@kyoto
Copy link
Member Author

kyoto commented Feb 16, 2020

/retest

spadgett
spadgett approved these changes Feb 16, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ea68168 into openshift:master Feb 17, 2020
@openshift-ci-robot
Copy link
Contributor

@kyoto: All pull requests linked via external trackers have merged. Bugzilla bug 1801847 has been moved to the MODIFIED state.

In response to this:

Bug 1801847: Monitoring Dashboards: Fix bar chart labels and fix row panels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyoto kyoto deleted the monitoring-dashboards-fix-bar-chart-labels branch February 17, 2020 02:22
@spadgett spadgett added this to the v4.4 milestone Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kyoto @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot