Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for Noobaa Bucket Class Creation Flow #4332

Merged
merged 1 commit into from Feb 26, 2020
Merged

Added tests for Noobaa Bucket Class Creation Flow #4332

merged 1 commit into from Feb 26, 2020

Conversation

bipuladh
Copy link
Contributor

  • Integration tests for Noobaa Bucket Class.
  • Tests all possible tier combinations.

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/noobaa Related to noobaa-storage-plugin labels Feb 17, 2020
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. component/backend Related to backend component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/monitoring Related to monitoring component/olm Related to OLM component/shared Related to console-shared and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 20, 2020
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 20, 2020
@bipuladh bipuladh force-pushed the nb-bc-tests branch 3 times, most recently from dc1d393 to 0ec50f7 Compare February 20, 2020 10:47
afreen23
afreen23 suggested changes Feb 24, 2020
View reviewed changes
frontend/packages/noobaa-storage-plugin/integration-tests/views/createBC.view.ts Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/integration-tests/tests/bucketClassTest.scenario.ts Outdated Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/integration-tests/tests/bucketClassTest.scenario.ts Outdated Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/integration-tests/tests/bucketClassTest.scenario.ts Outdated Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/integration-tests/tests/bucketClassTest.scenario.ts Outdated Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/integration-tests/tests/bucketClassTest.scenario.ts Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/integration-tests/views/createBC.view.ts Outdated Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/integration-tests/views/createBC.view.ts Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/integration-tests/views/createBC.view.ts Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/integration-tests/views/createBC.view.ts Show resolved Hide resolved
@afreen23
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, bipuladh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 26, 2020 •
edited

@bipuladh: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify 45625d4 link /test verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 586a2bb into openshift:master Feb 26, 2020
@spadgett spadgett added this to the v4.5 milestone Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnehapk gnehapk gnehapk left review comments

@afreen23 afreen23 afreen23 requested changes

Assignees

@afreen23 afreen23

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/monitoring Related to monitoring component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bipuladh @afreen23 @openshift-ci-robot @openshift-bot @gnehapk @spadgett @openshift-merge-robot