Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./test-backend.sh detects and runs all tests #4364

Merged
merged 1 commit into from Feb 27, 2020

Conversation

pedjak
Copy link
Contributor

@pedjak pedjak commented Feb 19, 2020

No need to manage per hand a list of packages having tests

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 19, 2020
@pedjak pedjak changed the title ./test-backend.sh detects and run all tests ./test-backend.sh detects and runs all tests Feb 19, 2020
@pedjak
Copy link
Contributor Author

pedjak commented Feb 19, 2020

/retest

@pedjak
Copy link
Contributor Author

pedjak commented Feb 19, 2020

/assign @benjaminapetersen

@@ -20,8 +20,8 @@ export GOFLAGS="-mod=vendor"
# Invoke ./cover for HTML output
COVER=${COVER:-"-cover"}

TESTABLE="pkg/auth pkg/proxy pkg/server pkg/helm/actions pkg/helm/handlers"
FORMATTABLE="${TESTABLE} cmd/bridge pkg/version"
TESTABLE="./..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, given I just left this comment! 👍

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020
@pedjak
Copy link
Contributor Author

pedjak commented Feb 24, 2020

/retest

No need to manage per hand a list of packages having tests
@pedjak
Copy link
Contributor Author

pedjak commented Feb 25, 2020

/retest

@pedjak
Copy link
Contributor Author

pedjak commented Feb 25, 2020

@benjaminapetersen e2e-gcp-console is failing constantly on this PR although the change is fully unrelated, blocking the merge. Can we do something about it?

@pedjak
Copy link
Contributor Author

pedjak commented Feb 26, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 26, 2020

@pedjak: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify 1c74693 link /test verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pedjak
Copy link
Contributor Author

pedjak commented Feb 26, 2020

/retest

@pedjak
Copy link
Contributor Author

pedjak commented Feb 27, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

@pedjak: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benjaminapetersen
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 74032c7 into openshift:master Feb 27, 2020
@spadgett spadgett added this to the v4.5 milestone Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants