New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1793962: make default template compatible with the VM Wizard #4378
Bug 1793962: make default template compatible with the VM Wizard #4378
Conversation
@suomiy: This pull request references Bugzilla bug 1793962, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@suomiy: This pull request references Bugzilla bug 1793962, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@suomiy: This pull request references Bugzilla bug 1793962, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-gcp-console |
You should also update the template yaml to reflect the new changes: Diffs I think needed: diff --git a/frontend/packages/kubevirt-plugin/src/models/templates/vm-template-yaml.ts b/frontend/packages/kubevirt-plugin/src/models/templates/vm-template-yaml.ts
index f6891eb3a..3c647dca4 100644
--- a/frontend/packages/kubevirt-plugin/src/models/templates/vm-template-yaml.ts
+++ b/frontend/packages/kubevirt-plugin/src/models/templates/vm-template-yaml.ts
@@ -45,11 +45,19 @@ objects:
- disk:
bus: virtio
name: cloudinitdisk
+ interfaces:
+ - masquerade: {}
+ name: default
+ networkInterfaceMultiqueue: true
+ rng: {}
machine:
type: ''
resources:
requests:
memory: '\${MEMORY}'
+ networks:
+ - name: default
+ pod: {}
terminationGracePeriodSeconds: 0 EDIT - even better is just to copy the template that is created by the code ( if you do that, you could remove the code and just use the template ) |
8463e67
to
3e20946
Compare
you are right! that is much better - using the generated values |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: suomiy, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@suomiy: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cherry-pick release-4.4 |
@jelkosz: new pull request created: #4549 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.