New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1808005: support multiple service binding request backingServiceSelectors #4381
Conversation
looks good, how to verify scenario for |
@invincibleJai I wrote the unit test for verification and ensured that the existing workflows continued to work. @sbose78 suggestions on testing the new CRD? I suppose we could just manually install the CRD and manually test without the operator even. |
/lgtm Verified locally existing workflows with SBR is working fine |
/retest Please review the full test history for this PR and help us cut down flakes. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, invincibleJai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@christianvogt: All pull requests linked via external trackers have merged. Bugzilla bug 1808005 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind bug |
/cherrypick release-4.4 |
@christianvogt: new pull request created: #4533 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.3 |
@rohitkrai03: #4381 failed to apply on top of branch "release-4.3":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
Fixes https://issues.redhat.com/browse/ODC-3119
Analysis / Root cause:
ServiceBindingRequest is adding support for multiple backing service selectors.
See example:
https://github.com/redhat-developer/service-binding-operator/tree/master/examples/multiple_services
Old spec will be deprecated and removed in the future.
Solution Description:
Added support for the new
spec.backingServiceSelectors
selectors.Kept backward compatibility with
spec.backingServiceSelector
.Solution first checks for new spec will fallback to old.
Added unit tests.
Browser conformance:
cc @sbose78 @invincibleJai