New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1809555: Retrieve the list of Helm charts via chart repo proxy endpoint #4389
Bug 1809555: Retrieve the list of Helm charts via chart repo proxy endpoint #4389
Conversation
@rohitkrai03 @pedjak , |
/test frontend |
/hold let's test it first on some clusters |
There's a lint error in the front end code. |
c631de4
to
67580b4
Compare
@christianvogt thanks, fixed. |
/retest |
@@ -27,7 +27,7 @@ func RegisterFlags(fs *flag.FlagSet) *config { | |||
|
|||
cfg := new(config) | |||
|
|||
fs.StringVar(&cfg.repoUrl, "helm-chart-repo-url", "https://redhat-developer.github.com/redhat-helm-charts", "Helm chart repository URL") | |||
fs.StringVar(&cfg.repoUrl, "helm-chart-repo-url", "https://redhat-developer.github.io/redhat-helm-charts", "Helm chart repository URL") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://redhat-developer.github.io/redhat-helm-charts/
is an HTML page. I'm guessing you don't want that as the default value here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do. HTML page is for humans, but UI fetches https://redhat-developer.github.io/redhat-helm-charts/index.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't proxy any HTML since we don't want to run any JS on the console domain. We should restrict the API to only proxy to the endpoint we want.
/retest |
@rohitkrai03 please review and test the front end |
/assign |
@rohitkrai03 we should also test it on a cluster |
Let me deploy this on a cluster.. |
@christianvogt @rohitkrai03 Did we validate it on a cluster? Can we remove hold? |
Rohit on slack: "Okay, so I just tested the PR on the above cluster deployment and everything works fine" We'll need a confirmation on the local testing. |
Predrag on slack |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Verified locally as well as on cluster. Works fine.
/assign @benjaminapetersen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm cancel
@@ -27,7 +27,7 @@ func RegisterFlags(fs *flag.FlagSet) *config { | |||
|
|||
cfg := new(config) | |||
|
|||
fs.StringVar(&cfg.repoUrl, "helm-chart-repo-url", "https://redhat-developer.github.com/redhat-helm-charts", "Helm chart repository URL") | |||
fs.StringVar(&cfg.repoUrl, "helm-chart-repo-url", "https://redhat-developer.github.io/redhat-helm-charts", "Helm chart repository URL") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't proxy any HTML since we don't want to run any JS on the console domain. We should restrict the API to only proxy to the endpoint we want.
The reverse proxy obtained via httputil.NewSingleHostReverseProxy does not follow redirects, and returns such requests to UI causing CORS issue, failing to load index.yaml from UI. Our default repo redhat-developer.github.com redirects to redhat-developer.github.io and in order to fix index.yaml loading, we started to use redhat-developer.github.io
67580b4
to
7de25fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak, rohitkrai03, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pedjak: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retitle Bug 1809555: Retrieve the list of Helm charts via chart repo proxy endpoint |
@pedjak: All pull requests linked via external trackers have merged. Bugzilla bug 1809555 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.4 |
@rohitkrai03: new pull request created: #4605 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The reverse proxy obtained via httputil.NewSingleHostReverseProxy does not follow redirects,
and returns such requests to UI causing CORS issue, failing to load index.yaml from UI.
Our default repo redhat-developer.github.com redirects to redhat-developer.github.io and in order
to fix index.yaml loading, we started to use redhat-developer.github.io