Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate CNV installation and uninstallation #4430

Merged
merged 1 commit into from Feb 26, 2020
Merged

Automate CNV installation and uninstallation #4430

merged 1 commit into from Feb 26, 2020

Conversation

guy9050
Copy link
Contributor

@guy9050 guy9050 commented Feb 23, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/kubevirt Related to kubevirt-plugin labels Feb 23, 2020
rhrazdil
rhrazdil suggested changes Feb 24, 2020
View reviewed changes
Copy link

@rhrazdil rhrazdil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments,

  • run frontend$ yarn lint --fix to fix liter issues

frontend/packages/kubevirt-plugin/integration-tests/Installation/cnv-uninstallation.scenario.ts Show resolved Hide resolved
frontend/packages/kubevirt-plugin/integration-tests/Installation/cnv-installation.scenario.ts Show resolved Hide resolved
frontend/packages/kubevirt-plugin/integration-tests/Installation/cnv-uninstallation.scenario.ts Outdated Show resolved Hide resolved
frontend/packages/kubevirt-plugin/package.json Outdated Show resolved Hide resolved
@rhrazdil
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2020
@guy9050
Copy link
Contributor Author

guy9050 commented Feb 24, 2020

@vojtechszocs can you please review?

@guy9050
Copy link
Contributor Author

guy9050 commented Feb 25, 2020

@rawagner can you please review this?

@rawagner
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guy9050, rawagner, rhrazdil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@guy9050
Copy link
Contributor Author

guy9050 commented Feb 26, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 26, 2020 •
edited

@guy9050: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify cbbb762 link /test verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f53380b into openshift:master Feb 26, 2020
@spadgett spadgett added this to the v4.5 milestone Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhrazdil rhrazdil rhrazdil requested changes

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@rhrazdil rhrazdil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@guy9050 @rhrazdil @rawagner @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot