Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.4] Bug 1805440: remove search button and search status/result for deploy image #4433

Merged
merged 1 commit into from Feb 26, 2020
Merged

[release-4.4] Bug 1805440: remove search button and search status/result for deploy image #4433

merged 1 commit into from Feb 26, 2020

Conversation

sahil143
Copy link
Contributor

@sahil143 sahil143 commented Feb 24, 2020 •
edited

cherry-pick of PR #4187 and added the fix for flaky functional test

This PR is dependent on #4392

@sahil143
remove search button and search status/result for deploy image
d50d3cf 
add validated text

show field required when searchTerm is empty

create scss file  for image search component,  use patternfly validatedOption enum

add data-test-id to ImageSearch component

add classes for success help text

s

remove styles

removed funtional test because Input search button is removed and no longer used

remove $

fix functional tests

show inline error for ImageStream

add error

refactor

reorder Imports

fix functional test
@openshift-ci-robot
Copy link
Contributor

@sahil143: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

remove search button and search status/result for deploy image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 24, 2020
@sahil143 sahil143 changed the title remove search button and search status/result for deploy image [release-4.4] Bug 1805440: remove search button and search status/result for deploy image Feb 24, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 24, 2020
@openshift-ci-robot
Copy link
Contributor

@sahil143: This pull request references Bugzilla bug 1805440, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

[release-4.4] Bug 1805440: remove search button and search status/result for deploy image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console component/shared Related to console-shared labels Feb 24, 2020
@sahil143 sahil143 mentioned this pull request Feb 24, 2020
Closed
@vikram-raj
Copy link
Member

/retest

@sahil143
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2020
@openshift-ci-robot
Copy link
Contributor

@sahil143: This pull request references Bugzilla bug 1805440, which is valid.

In response to this:

[release-4.4] Bug 1805440: remove search button and search status/result for deploy image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sahil143
Copy link
Contributor Author

Build is failing because this PR is dependent on #4392.

@andrewballantyne
Copy link
Contributor

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 24, 2020
@spadgett spadgett added this to the v4.4 milestone Feb 24, 2020
vikram-raj
vikram-raj reviewed Feb 25, 2020
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2020
@vikram-raj
Copy link
Member

/retest

1 similar comment
@sahil143
Copy link
Contributor Author

/retest

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2020
@openshift-merge-robot openshift-merge-robot merged commit 8a4b0f2 into openshift:release-4.4 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikram-raj vikram-raj vikram-raj left review comments

@abhi-kn abhi-kn Awaiting requested review from abhi-kn

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

Assignees

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console component/shared Related to console-shared kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sahil143 @openshift-ci-robot @vikram-raj @andrewballantyne @christianvogt @spadgett @openshift-merge-robot