Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1805292: Do not clear event list on error #4437

Merged

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Feb 24, 2020

When a user navigates to Events tab of a VM, the page keeps scrollig up.

Description:
On bad connections events stream may connect and disconnect, currently on each error we clear
the events list and course the list to flicker, and on long disconnections to scroll up. but we do not need to clear the list of event on errors because if the connection will resume, we can continue from the previous points, and only if connection will die completely we will want to alert the user.

Before (with flicker):
Peek 2020-02-24 15-30

After (without flicker):
Peek 2020-02-24 15-33

@openshift-ci-robot
Copy link
Contributor

@yaacov: This pull request references Bugzilla bug 1805292, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1805292: Do not clear event list on error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 24, 2020
@yaacov yaacov requested a review from spadgett February 24, 2020 13:45
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/core Related to console core functionality labels Feb 24, 2020
@yaacov
Copy link
Member Author

yaacov commented Feb 24, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 24, 2020
@openshift-ci-robot
Copy link
Contributor

@yaacov: This pull request references Bugzilla bug 1805292, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 24, 2020
@yaacov
Copy link
Member Author

yaacov commented Feb 24, 2020

@spadgett @rawagner please review

})
.onclose((evt) => {
if (evt && evt.wasClean === false) {
this.setState({ error: evt.reason || 'Connection did not close cleanly.' });
}
this.messages = {};
this.setState({ sortedMessages: [], filteredEvents: [] });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove the messages onclose()?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happen when I tried to repruduce the bug:
a - close
b - open
so to prevent the flicker I needed to remove the list clear from open and close ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the flicker happens because a new set of events is overriding the old one.
maybe theres a better way to handle this to avoid multiple fetches in a short period of time, but I guess not for this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, you mean the this.messages = {}; 👍 removing it.

@openshift-ci-robot
Copy link
Contributor

@yaacov: This pull request references Bugzilla bug 1805292, which is valid.

In response to this:

Bug 1805292: Do not clear event list on error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yaacov
Copy link
Member Author

yaacov commented Feb 27, 2020

@spadgett please review

1 similar comment
@yaacov
Copy link
Member Author

yaacov commented Mar 3, 2020

@spadgett please review

@yaacov
Copy link
Member Author

yaacov commented Mar 9, 2020

@spadgett ?

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

We should eventually replace EventStream with Firehose, but this seems like a reasonable fix until we make that change.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 10, 2020

@yaacov: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify 7fc3788 link /test verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yaacov
Copy link
Member Author

yaacov commented Mar 10, 2020

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4046665 into openshift:master Mar 10, 2020
@openshift-ci-robot
Copy link
Contributor

@yaacov: All pull requests linked via external trackers have merged. Bugzilla bug 1805292 has been moved to the MODIFIED state.

In response to this:

Bug 1805292: Do not clear event list on error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants