New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1805292: Do not clear event list on error #4437
Bug 1805292: Do not clear event list on error #4437
Conversation
@yaacov: This pull request references Bugzilla bug 1805292, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@yaacov: This pull request references Bugzilla bug 1805292, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
}) | ||
.onclose((evt) => { | ||
if (evt && evt.wasClean === false) { | ||
this.setState({ error: evt.reason || 'Connection did not close cleanly.' }); | ||
} | ||
this.messages = {}; | ||
this.setState({ sortedMessages: [], filteredEvents: [] }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not remove the messages onclose()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happen when I tried to repruduce the bug:
a - close
b - open
so to prevent the flicker I needed to remove the list clear from open and close ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the flicker happens because a new set of events is overriding the old one.
maybe theres a better way to handle this to avoid multiple fetches in a short period of time, but I guess not for this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, you mean the this.messages = {};
👍 removing it.
@yaacov: This pull request references Bugzilla bug 1805292, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@spadgett please review |
1 similar comment
@spadgett please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
We should eventually replace EventStream
with Firehose
, but this seems like a reasonable fix until we make that change.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yaacov: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test e2e-gcp-console |
/retest Please review the full test history for this PR and help us cut down flakes. |
@yaacov: All pull requests linked via external trackers have merged. Bugzilla bug 1805292 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When a user navigates to Events tab of a VM, the page keeps scrollig up.
Description:
On bad connections events stream may connect and disconnect, currently on each error we clear
the events list and course the list to flicker, and on long disconnections to scroll up. but we do not need to clear the list of event on errors because if the connection will resume, we can continue from the previous points, and only if connection will die completely we will want to alert the user.
Before (with flicker):
After (without flicker):