Bug 1806914: redirect to topology when resource created from dev-catalog #4459

sahil143 · 2020-02-25T10:09:08Z

ODC-Bug: https://issues.redhat.com/browse/ODC-3152

This PR adds functionality to redirect page to the topology page when a resource is installed from dev-catalog.

Template

Operator-backed

openshift-ci-robot · 2020-02-25T10:09:16Z

@sahil143: This pull request references Bugzilla bug 1806914, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1806914: redirect to topology when resource created from dev-catalog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne · 2020-02-25T18:55:05Z

frontend/packages/operator-lifecycle-manager/src/components/create-operand.tsx

-              )}/${referenceForModel(operandModel)}`,
-            ),
-          )
+          .then(() => history.push(`/topology`))


Maybe check for dev perspective? Not sure we want to do this at all times.

andrewballantyne · 2020-02-25T18:55:14Z

/kind bug

sahil143 · 2020-02-27T06:56:45Z

/retest

rohitkrai03 · 2020-02-28T14:33:12Z

frontend/packages/operator-lifecycle-manager/src/components/create-operand.tsx

-              )}/${referenceForModel(operandModel)}`,
-            ),
-          )
+              params.has('redirect')


Why not use perspective extension to get the redirect URL based on perspective similar to how import from git does it right now?

rohitkrai03 · 2020-02-28T20:29:14Z

frontend/public/components/catalog/catalog-items.tsx

@@ -346,7 +357,7 @@ export class CatalogTileViewPage extends React.Component<
                <div className="co-catalog-page__overlay-actions">
                  <Link
                    className="pf-c-button pf-m-primary co-catalog-page__overlay-action"
-                    to={detailsItem.href}
+                    to={this.appendTopologyRedirect(detailsItem.href)}


It's just hard coding the URL redirect to topology which means that user can be in any perspective and still he will be redirected to topology. Is this the behavior that we want here? I would prefer if the redirect happens based on current perspective. cc: @christianvogt

Below screencast shows that even if the user is in admin perspective, he is redirected to topology.

This can be avoided now that the implementation is changed to use active Perspective.

rohitkrai03 · 2020-02-28T20:30:59Z

frontend/packages/operator-lifecycle-manager/src/components/create-operand.tsx

-    )}/${props.match.params.plural}`;
+  const resourceObjPath = () => {
+    const params = new URLSearchParams(window.location.href);
+    return params.has('redirect')


This doesn't work for operator backed services when I tested it. For some reason the redirect param that is added is being removed on this page which results in user getting redirected to default admin URL.

@rohitkrai03 Not sure why the param is being removed but I changed the implementation to use activePerspective.

rohitkrai03 · 2020-03-02T11:08:29Z

/assign

rohitkrai03

/lgtm

christianvogt · 2020-03-02T16:44:41Z

FYI @alecmerdler @spadgett

We want to provide a catalog extension in the future for contributing items to the dev catalog. In doing that we will refactor how operands are created via the catalog to avoid reusing the same shared route. We will then remove the additions here which redirect to topology.

spadgett · 2020-03-02T16:51:15Z

What happens when the template instance fails?

This might also be really confusing if the template doesn't create any resources that are visible in the topology.

spadgett · 2020-03-02T16:52:37Z

I have a similar question for operator-backed resources. Will the thing you create and its status always be apparent from the topology page?

christianvogt · 2020-03-02T16:58:48Z

@spadgett had the same concerns before and UX said they wanted to always redirect to topology out of the dev catalog in the developer perspective.

cc @openshift/team-devconsole-ux

christianvogt · 2020-03-03T13:21:18Z

/approve

andrewballantyne · 2020-03-04T20:54:51Z

/lgtm

openshift-ci-robot · 2020-03-04T20:55:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, rohitkrai03, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

andrewballantyne · 2020-03-04T22:22:51Z

/test e2e-gcp-console

openshift-bot · 2020-03-05T00:13:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-05T00:52:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-05T02:23:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-03-05T03:41:39Z

@sahil143: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/verify	`f079ca5`	link	`/test verify`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-03-05T04:59:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-05T05:12:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-05T05:25:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-05T05:38:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-05T05:51:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-05T06:04:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-05T06:17:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

add activePErspective

sahil143 · 2020-03-05T10:44:04Z

/retest

sahil143 · 2020-03-05T11:28:49Z

/cherrypick release-4.4

openshift-cherrypick-robot · 2020-03-05T11:28:51Z

@sahil143: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-05T12:12:55Z

@sahil143: All pull requests linked via external trackers have merged. Bugzilla bug 1806914 has been moved to the MODIFIED state.

In response to this:

Bug 1806914: redirect to topology when resource created from dev-catalog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-03-05T12:13:09Z

@sahil143: #4459 failed to apply on top of branch "release-4.4":

Using index info to reconstruct a base tree...
A	frontend/packages/operator-lifecycle-manager/src/components/create-operand-form.tsx
M	frontend/packages/operator-lifecycle-manager/src/components/create-operand.spec.tsx
M	frontend/packages/operator-lifecycle-manager/src/components/create-operand.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/operator-lifecycle-manager/src/components/create-operand.tsx
CONFLICT (content): Merge conflict in frontend/packages/operator-lifecycle-manager/src/components/create-operand.tsx
Auto-merging frontend/packages/operator-lifecycle-manager/src/components/create-operand.spec.tsx
CONFLICT (modify/delete): frontend/packages/operator-lifecycle-manager/src/components/create-operand-form.tsx deleted in HEAD and modified in redirect to topology when resource created from dev-catalog. Version redirect to topology when resource created from dev-catalog of frontend/packages/operator-lifecycle-manager/src/components/create-operand-form.tsx left in tree.
error: Failed to merge in the changes.
Patch failed at 0001 redirect to topology when resource created from dev-catalog

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sahil143 · 2020-03-05T17:58:43Z

/cherrypick release-4.4

openshift-cherrypick-robot · 2020-03-05T17:58:52Z

@sahil143: new pull request created: #4661

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 25, 2020

openshift-ci-robot requested review from jeff-phillips-18 and jhadvig February 25, 2020 10:09

openshift-ci-robot added component/core Related to console core functionality component/olm Related to OLM labels Feb 25, 2020

sahil143 changed the title ~~Bug 1806914: redirect to topology when resource created from dev-catalog~~ [WIP] Bug 1806914: redirect to topology when resource created from dev-catalog Feb 25, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2020

andrewballantyne reviewed Feb 25, 2020

View reviewed changes

openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 25, 2020

sahil143 force-pushed the dev-catalog-redirect branch from f079ca5 to 8c2fcf1 Compare February 26, 2020 06:50

sahil143 changed the title ~~[WIP] Bug 1806914: redirect to topology when resource created from dev-catalog~~ Bug 1806914: redirect to topology when resource created from dev-catalog Feb 26, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2020

sahil143 force-pushed the dev-catalog-redirect branch from 8c2fcf1 to 7f2aa16 Compare February 26, 2020 14:51

rohitkrai03 suggested changes Feb 28, 2020

View reviewed changes

sahil143 force-pushed the dev-catalog-redirect branch from 7f2aa16 to 8c2fcf1 Compare March 2, 2020 10:24

openshift-ci-robot assigned rohitkrai03 Mar 2, 2020

rohitkrai03 approved these changes Mar 2, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2020

sahil143 force-pushed the dev-catalog-redirect branch from 45369f0 to ccded55 Compare March 4, 2020 20:51

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2020

redirect to topology when resource created from dev-catalog

1d7137f

add activePErspective

sahil143 force-pushed the dev-catalog-redirect branch from ccded55 to 1d7137f Compare March 5, 2020 06:19

openshift-merge-robot merged commit feb8b65 into openshift:master Mar 5, 2020

sahil143 mentioned this pull request Mar 5, 2020

[release-4.4] Bug 1810382: redirect to topology when resource created from dev-catalog #4657

Closed

openshift-cherrypick-robot mentioned this pull request Mar 5, 2020

[release-4.4] Bug 1810382: redirect to topology when resource created from dev-catalog #4661

Merged

spadgett added this to the v4.5 milestone Mar 9, 2020

Bug 1806914: redirect to topology when resource created from dev-catalog #4459

Bug 1806914: redirect to topology when resource created from dev-catalog #4459

Conversation

sahil143 commented Feb 25, 2020

openshift-ci-robot commented Feb 25, 2020

andrewballantyne Feb 25, 2020

Choose a reason for hiding this comment

andrewballantyne commented Feb 25, 2020

sahil143 commented Feb 27, 2020

rohitkrai03 Feb 28, 2020

Choose a reason for hiding this comment

rohitkrai03 Feb 28, 2020 • edited

Choose a reason for hiding this comment

sahil143 Mar 2, 2020

Choose a reason for hiding this comment

rohitkrai03 Feb 28, 2020

Choose a reason for hiding this comment

sahil143 Mar 2, 2020

Choose a reason for hiding this comment

rohitkrai03 commented Mar 2, 2020

rohitkrai03 left a comment

Choose a reason for hiding this comment

christianvogt commented Mar 2, 2020

spadgett commented Mar 2, 2020

spadgett commented Mar 2, 2020

christianvogt commented Mar 2, 2020 • edited

christianvogt commented Mar 3, 2020

andrewballantyne commented Mar 4, 2020

openshift-ci-robot commented Mar 4, 2020

andrewballantyne commented Mar 4, 2020

openshift-bot commented Mar 5, 2020

openshift-bot commented Mar 5, 2020

openshift-bot commented Mar 5, 2020

openshift-ci-robot commented Mar 5, 2020 • edited

openshift-bot commented Mar 5, 2020

openshift-bot commented Mar 5, 2020

openshift-bot commented Mar 5, 2020

openshift-bot commented Mar 5, 2020

openshift-bot commented Mar 5, 2020

openshift-bot commented Mar 5, 2020

openshift-bot commented Mar 5, 2020

sahil143 commented Mar 5, 2020

sahil143 commented Mar 5, 2020

openshift-cherrypick-robot commented Mar 5, 2020

openshift-ci-robot commented Mar 5, 2020

openshift-cherrypick-robot commented Mar 5, 2020

sahil143 commented Mar 5, 2020

openshift-cherrypick-robot commented Mar 5, 2020

rohitkrai03 Feb 28, 2020 •

edited

christianvogt commented Mar 2, 2020 •

edited

openshift-ci-robot commented Mar 5, 2020 •

edited