Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1807142: fix CPU and RAM editing in Flavor dialog #4477

Merged
merged 1 commit into from Feb 26, 2020
Merged

Bug 1807142: fix CPU and RAM editing in Flavor dialog #4477

merged 1 commit into from Feb 26, 2020

Conversation

atiratree
Copy link
Member

@atiratree atiratree commented Feb 25, 2020 •
edited

  • fields can be fully edited
  • added a unit field for RAM
  • fixed design
  • added validations

backport of #4353

@suomiy
Bug 1807142: fix CPU and RAM editing in Flavor dialog
a2f2626 
- fields can be fully edited
- added a unit field for RAM
- fixed design
- added validations
@openshift-ci-robot
Copy link
Contributor

@suomiy: This pull request references Bugzilla bug 1807142, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1807142: fix CPU and RAM editing in Flavor dialog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 25, 2020
@openshift-ci-robot
Copy link
Contributor

@suomiy: This pull request references Bugzilla bug 1807142, which is valid.

In response to this:

Bug 1807142: fix CPU and RAM editing in Flavor dialog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

2 similar comments
@openshift-ci-robot
Copy link
Contributor

@suomiy: This pull request references Bugzilla bug 1807142, which is valid.

In response to this:

Bug 1807142: fix CPU and RAM editing in Flavor dialog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@suomiy: This pull request references Bugzilla bug 1807142, which is valid.

In response to this:

Bug 1807142: fix CPU and RAM editing in Flavor dialog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yaacov
Copy link
Member

yaacov commented Feb 25, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suomiy, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2020
@spadgett spadgett added this to the v4.4 milestone Feb 25, 2020
@spadgett spadgett added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 25, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2b35bd3 into openshift:release-4.4 Feb 26, 2020
@openshift-ci-robot
Copy link
Contributor

@suomiy: All pull requests linked via external trackers have merged. Bugzilla bug 1807142 has been moved to the MODIFIED state.

In response to this:

Bug 1807142: fix CPU and RAM editing in Flavor dialog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelkosz jelkosz Awaiting requested review from jelkosz

@yaacov yaacov Awaiting requested review from yaacov

Assignees

@yaacov yaacov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@atiratree @openshift-ci-robot @yaacov @spadgett @openshift-merge-robot @suomiy