Bug 1805899: Make selected items show check mark in dropdown #4489
Conversation
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@zherman0: This pull request references Bugzilla bug 1805899, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
component/core
|
/assign @benjaminapetersen |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, zherman0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/cherry-pick release-4.4 |
|
@benjaminapetersen: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@zherman0: All pull requests linked via external trackers have merged. Bugzilla bug 1805899 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@benjaminapetersen: new pull request created: #4515 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The value from the dropdown select did not match the expected key for the check boxes in the dropdown for most standard resource types. This meant the checkbox might not be checked for a selected resource.
As for the solution, the underlying models are stored in an orderedmap of key:model. The key for most common resources are simply the kind name, i.e. "Pod" or "PersistentVolumeClaim". However, my dropdown checkbox uses the more specific group
versionkind key (i.e. "corev1Pod") to prevent any ambiguity. Instead of changing the orderedMap, I simply inject the full group-version-kind value into the selected value which is preferred to prevent future ambiguity.