Bug 1807210: added Time Range & Refresh Interval dropdowns in monitoring dashboard #4519
Conversation
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@abhi-kn: This pull request references Bugzilla bug 1807210, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) run on this bug- bug is open, matching expected state (open) - bug target release (4.5.0) matches configured target release for branch (4.5.0) - bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/kind bug |
openshift-ci-robot
added
kind/bug
|
/assign @vikram-raj |
|
/bugzilla refresh The requirements for Bugzilla bugs have changed, recalculating validity. |
|
@openshift-bot: This pull request references Bugzilla bug 1807210, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This looks like it's mostly a copy / paste of the code from the admin dashboard. Shouldn't we be creating some shared components instead? |
abhi-kn
changed the title
|
Although we haven't investigated this yet, I believe longer term we want to share the dashboard component as a whole and will require further refactoring. @abhi-kn why not export the existing components and use them as is for now? |
openshift-ci-robot
added
size/M
abhi-kn
changed the title
openshift-ci-robot
added
component/core
|
@abhi-kn: This pull request references Bugzilla bug 1807210, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@abhi-kn: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| display: flex; | ||
| float: right; | ||
| align-self: flex-end; | ||
| margin-top: -65px; |
There was a problem hiding this comment.
For now this is fine.
We should push back on UX for this in future because:
- we don't have components for this right now
- it's a contextual item that appears at the same height as the tabs that set the context below
- there's no consideration for responsive mobile layout. Right now it overlaps the tabs on mobile.
cc @openshift/team-devconsole-ux
frontend/packages/dev-console/src/components/monitoring/dashboard/MonitoringDashboard.scss
Outdated
Show resolved
Hide resolved
|
/retest |
frontend/packages/dev-console/src/components/monitoring/dashboard/MonitoringDashboard.tsx
Outdated
Show resolved
Hide resolved
...kages/dev-console/src/components/monitoring/dashboard/__tests__/MonitoringDashboard.spec.tsx
Show resolved
Hide resolved
|
/lgtm verified locally |
|
/approve |
openshift-ci-robot
added
approved
openshift-ci-robot
removed
lgtm
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhi-kn, christianvogt, invincibleJai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@abhi-kn: All pull requests linked via external trackers have merged. Bugzilla bug 1807210 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@abhi-kn: new pull request created: #4581 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-2822
Analysis / Root cause:
Time Range & Refresh Interval drop downs in monitoring dashboard tab have been added in design lately.
Solution Description:
Time Range & Refresh Interval drop down list & functionalities required in dev-console monitoring dashboard tab is same as of Admin console. Hence exported Time Range & Refresh Interval drop downs components in
@console/internal/components/monitoring/dashboards. And reused them in dev-console Monitoring Dashboard tab. With this dropdown selected values persist between Admin console Dashboard page & Dev-console Dashboard page.Screen shots / Gifs for design review:
@openshift/team-devconsole-ux
Unit test coverage report:
Test setup: N/A
Browser conformance: