Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1808144: Pipeline builder ux changes #4520

Merged
merged 5 commits into from Feb 28, 2020
Merged

Bug 1808144: Pipeline builder ux changes #4520

merged 5 commits into from Feb 28, 2020

Conversation

andrewballantyne
Copy link
Contributor

@andrewballantyne andrewballantyne commented Feb 26, 2020 •
edited

Fixes:

https://issues.redhat.com/browse/ODC-3169
https://issues.redhat.com/browse/ODC-3130
https://issues.redhat.com/browse/ODC-3132
https://issues.redhat.com/browse/ODC-3186

Analysis / Root cause:

UX has raised some minor issues regarding the overall flow.

Solution Description:

Address some of UX's desires to improve the experience.

Screen shots / Gifs for design review:

PipelineBuilderUX_QoL

Screen Shot 2020-02-26 at 4 51 04 PM
Screen Shot 2020-02-26 at 4 51 11 PM
Screen Shot 2020-02-26 at 4 51 18 PM

@openshift/team-devconsole-ux

Unit test coverage report:
No changes

Test setup:

  • Pipeline Operator
  • Create Pipeline

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

/kind bug

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console labels Feb 26, 2020
serenamarie125
serenamarie125 approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are looking good! Thanks for addressing the issues

sahil143
sahil143 reviewed Feb 27, 2020
View reviewed changes
Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewballantyne Clicking on one of the tasks opens the sidebar but clicking on it again does nothing because of this sidebar can only be closed by clicking outside area of tasks. I was expecting it to close on the second click as it does on topology.
sidebar

@andrewballantyne
Copy link
Contributor Author

@sahil143 Thanks for the comment, I've addressed the code and fixed that scenario.

christianvogt
christianvogt reviewed Feb 27, 2020
View reviewed changes
...le/src/components/pipelines/detail-page-tabs/pipeline-details/PipelineVisualizationTask.scss Outdated Show resolved Hide resolved
...ole/src/components/pipelines/detail-page-tabs/pipeline-details/PipelineVisualizationTask.tsx Outdated Show resolved Hide resolved
frontend/packages/dev-console/src/components/pipelines/pipeline-builder/PipelineBuilderForm.tsx Show resolved Hide resolved
...tend/packages/dev-console/src/components/pipelines/pipeline-builder/task-sidebar/Sidebar.tsx Outdated Show resolved Hide resolved
...packages/dev-console/src/components/pipelines/pipeline-builder/task-sidebar/TaskSidebar.scss Outdated
@@ -5,6 +5,7 @@
}

&__header, &__content {
height: 33px; // fixed height header to avoid actions from bouncing the header
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eww :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the ActionsMenu remounts... the useEffect hook it uses sets the state immediately for my use case and somehow manages to get a render in there and causes the UI to flicker the dropdown in.

@andrewballantyne andrewballantyne changed the title Pipeline builder ux changes Bug 1808144: Pipeline builder ux changes Feb 27, 2020
@openshift-ci-robot
Copy link
Contributor

@andrewballantyne: This pull request references Bugzilla bug 1808144, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1808144: Pipeline builder ux changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 27, 2020
@andrewballantyne
Copy link
Contributor Author

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@andrewballantyne: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sahil143
sahil143 reviewed Feb 28, 2020
View reviewed changes
Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Verified changes locally

@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, serenamarie125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 68c4313 into openshift:master Feb 28, 2020
@openshift-ci-robot
Copy link
Contributor

@andrewballantyne: All pull requests linked via external trackers have merged. Bugzilla bug 1808144 has been moved to the MODIFIED state.

In response to this:

Bug 1808144: Pipeline builder ux changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 28, 2020
Merged
@openshift-cherrypick-robot
Copy link

@andrewballantyne: new pull request created: #4564

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahil143 sahil143 sahil143 left review comments

@christianvogt christianvogt christianvogt left review comments

@serenamarie125 serenamarie125 serenamarie125 approved these changes

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@andrewballantyne @openshift-ci-robot @openshift-cherrypick-robot @christianvogt @sahil143 @serenamarie125 @spadgett @openshift-merge-robot