Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1801395: Monitoring Dashboards: Fix stack chart Y axis when all values are zero #4524

Merged
merged 1 commit into from Feb 27, 2020
Merged

Bug 1801395: Monitoring Dashboards: Fix stack chart Y axis when all values are zero #4524

merged 1 commit into from Feb 27, 2020

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Feb 27, 2020

The stack chart Y axis should have the range [-1, 1] when all values are
zero. This matches the behavior of the line (non-stack) chart.

Before After
before after

@kyoto
Monitoring Dashboards: Fix stack chart Y axis when all values are zero
44e8bb8 
The stack chart Y axis should have the range [-1, 1] when all values are
zero. This matches the behavior of the line (non-stack) chart.
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 27, 2020
@openshift-ci-robot
Copy link
Contributor

@kyoto: This pull request references Bugzilla bug 1801395, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1801395: Monitoring Dashboards: Fix stack chart Y axis when all values are zero

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/core Related to console core functionality component/monitoring Related to monitoring labels Feb 27, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2020
@kyoto
Copy link
Member Author

kyoto commented Feb 27, 2020

/retest

@spadgett
Copy link
Member

Would 0-1 be better? That also matches Grafana.

Screenshot_2020-02-27 Prometheus - Grafana

@spadgett
Copy link
Member

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone Feb 27, 2020
@spadgett
Copy link
Member

OK I see this is consistent with other charts that aren't stacks.

spadgett
spadgett approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cdb3e88 into openshift:master Feb 27, 2020
@spadgett
Copy link
Member

/cherry-pick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 27, 2020
Merged
@openshift-cherrypick-robot
Copy link

@spadgett: new pull request created: #4536

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyoto kyoto deleted the monitoring-dashboards-fix-y-axis-range branch February 28, 2020 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kyoto @openshift-ci-robot @spadgett @openshift-cherrypick-robot @openshift-merge-robot