New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1806912: Monitoring Dashboards: Fix X axis tick labels overlapping #4526
Bug 1806912: Monitoring Dashboards: Fix X axis tick labels overlapping #4526
Conversation
Simplify the panel layouts to either - For `md` widths and over, respect the dashboard definition panel widths - For smaller widths, every panel is full width
When graphs are small, the X axis tick labels were overlapping. This fixes that by changing the label font size and angle at small widths.
@kyoto: This pull request references Bugzilla bug 1806912, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@kyoto: This pull request references Bugzilla bug 1806912, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
FYI @cshinn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cherry-pick release-4.4 |
@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@spadgett: new pull request created: #4534 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When graphs are small, the X axis tick labels were overlapping. This
fixes that by changing the label font size and angle at small widths.
Also fixes panel layout for intermediate page widths.
With this change, all panels become full width at
sm
page widths.The panel layout logic change does cause the "Kubernetes / Compute Resources / Cluster" single value panels to have a gap on the second row at
md
widths (see below). I think this is acceptable since this change fixes the other layout issues and is also a little simpler.