Bug 1807868: fixes issue with knative service in edit flow #4528

invincibleJai · 2020-02-27T12:08:33Z

Fixes:
https://issues.redhat.com/browse/ODC-3069

Analysis / Root cause:
On editing knative Service from topology view with different image not creating new revision.

Solution Description:
In case of knative service edit generating new Image Stream with name-randomChars and update service with new image registry url and filtering image stream based on instance name.

Screen shots / Gifs for design review:

Browser conformance:

Chrome
Firefox
Safari
Edge

openshift-ci-robot · 2020-02-27T12:11:34Z

@invincibleJai: This pull request references Bugzilla bug 1807868, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1807868: fixes issue with knative service in edit flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vikram-raj · 2020-02-27T12:37:33Z

frontend/packages/dev-console/src/components/edit-application/edit-application-types.ts

@@ -5,7 +5,7 @@ export interface AppResources {
  service?: FirehoseResult<K8sResourceKind>;
  route?: FirehoseResult<K8sResourceKind>;
  buildConfig?: FirehoseResult<K8sResourceKind>;
-  imageStream?: FirehoseResult<K8sResourceKind>;
+  imageStream?: FirehoseResult;


Suggested change

imageStream?: FirehoseResult;

imageStream?: FirehoseResult<K8sResourceKind[]>;

vikram-raj

Tested all the scenario it working fine with this changes.
/lgtm

andrewballantyne · 2020-02-28T21:23:35Z

frontend/packages/dev-console/src/components/import/deployImage-submit-utils.ts

@@ -22,6 +22,7 @@ import {
 import { RegistryType } from '../../utils/imagestream-utils';
 import { AppResources } from '../edit-application/edit-application-types';
 import { DeployImageFormData, Resources } from './import-types';
+import { getRandomChars } from '../pipelines/pipeline-resource/pipelineResource-utils';


We need to be putting this function in a nicer location... import for knative pulling from pipelines is odd.

We can probably leave this for the sake for 4.4 getting done but we should log a refactor task to clean this up.

We could probably keep this to dev-console though...

can we have it in under dev-console/utils in shared-submit-utils.ts ?

Yeah, that's works

andrewballantyne · 2020-02-28T21:26:38Z

frontend/packages/dev-console/src/components/import/deployImage-submit-utils.ts

@@ -90,12 +95,18 @@ export const createOrUpdateImageStream = (
      ],
    },
  };
-
+  if (formData.resources === Resources.KnativeService && !_.isEmpty(originalImageStream)) {
+    const OrignalImageStreamTag = _.find(originalImageStream?.status?.tags, ['tag', tag]);


Suggested change

const OrignalImageStreamTag = _.find(originalImageStream?.status?.tags, ['tag', tag]);

const orignalImageStreamTag = _.find(originalImageStream?.status?.tags, ['tag', tag]);

Not sure why this got a capital... it's just a value like anything else.

andrewballantyne · 2020-02-28T21:45:26Z

frontend/packages/dev-console/src/components/import/import-submit-utils.ts


+let generatedImageStreamName: string;


Oh yikes... the reason this is outside of the function is that you're sharing it between functions... this is not ideal in anyway. Bump this variable up a scope and then pass it through to the functions as needed.

Looks like the goal of this is to revalue name... perhaps do it seamlessly at the top level by reworking the "formData" to include the repurposed name before it's passed down. This feels like a hack where one (I don't think) is needed.

yeah, this was bad. have updated it. Thanks

andrewballantyne · 2020-03-02T13:46:16Z

/kind bug

andrewballantyne

Tiny typo

andrewballantyne · 2020-03-02T14:31:23Z

frontend/packages/dev-console/src/components/import/deployImage-submit-utils.ts

@@ -402,11 +401,22 @@ export const createOrUpdateDeployImageResources = async (
    // Do not run serverless call during the dry run.
    let imageStreamUrl: string = image?.dockerImageReference;
    if (registry === RegistryType.External) {
+      let generatedImageStreamName: string = '';
+      if (imageStreamList && imageStreamList.length && verb === 'update') {
+        const orignalImageStreamTag = _.find(originalImageStream?.status?.tags, [


Suggested change

const orignalImageStreamTag = _.find(originalImageStream?.status?.tags, [

const originalImageStreamTag = _.find(originalImageStream?.status?.tags, [

andrewballantyne

/lgtm
/approve

invincibleJai · 2020-03-02T15:16:31Z

/cherry-pick release-4.4

openshift-cherrypick-robot · 2020-03-02T15:16:33Z

@invincibleJai: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-02T15:19:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, invincibleJai, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/dev-console/OWNERS~~ [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

andrewballantyne · 2020-03-02T15:54:56Z

/test analyze

Bundle size flake.

andrewballantyne · 2020-03-02T18:59:02Z

✖ should deploy the image and display it in the topology (3 failures)

Well that's not a good test to see fail... Going to rerun... hopefully this is not one of those times this flake holds down the PR.

/retest

openshift-bot · 2020-03-02T19:22:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-02T21:18:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-02T22:49:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

christianvogt · 2020-03-02T23:12:00Z

/cherrypick release-4.4

openshift-cherrypick-robot · 2020-03-02T23:12:01Z

@christianvogt: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-03-03T00:07:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T01:25:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T02:43:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T02:56:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

invincibleJai · 2020-03-03T03:17:16Z

will force push help here?

out of 13 runs , twice pull-ci-openshift-console-master-e2e-gcp-console passed looks like

openshift-bot · 2020-03-03T03:35:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T03:48:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T04:27:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T04:40:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T05:20:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T05:32:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T06:11:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T06:24:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T09:13:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-03-03T15:02:37Z

@invincibleJai: All pull requests linked via external trackers have merged. Bugzilla bug 1807868 has been moved to the MODIFIED state.

In response to this:

Bug 1807868: fixes issue with knative service in edit flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-03-03T15:02:58Z

@invincibleJai: new pull request created: #4610

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/dev-console Related to dev-console labels Feb 27, 2020

openshift-ci-robot requested review from debsmita1 and karthikjeeyar February 27, 2020 12:09

invincibleJai changed the title ~~fixes issue with knative service in edit flow~~ Bug 1807868: fixes issue with knative service in edit flow Feb 27, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 27, 2020

vikram-raj reviewed Feb 27, 2020

View reviewed changes

invincibleJai force-pushed the fix-kn-svc-img-edit branch from a81d2b1 to d595519 Compare February 27, 2020 12:45

vikram-raj reviewed Feb 27, 2020

View reviewed changes

openshift-ci-robot assigned vikram-raj Feb 27, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2020

andrewballantyne suggested changes Feb 28, 2020

View reviewed changes

openshift-ci-robot assigned andrewballantyne Feb 28, 2020

invincibleJai force-pushed the fix-kn-svc-img-edit branch from 37f80fe to 2109843 Compare March 2, 2020 12:07

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2020

invincibleJai force-pushed the fix-kn-svc-img-edit branch 2 times, most recently from b21fe93 to 71fb7d2 Compare March 2, 2020 12:46

openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 2, 2020

andrewballantyne approved these changes Mar 2, 2020

View reviewed changes

fixes issue with knative service in edit flow

d4005c3

invincibleJai force-pushed the fix-kn-svc-img-edit branch from 71fb7d2 to d4005c3 Compare March 2, 2020 15:13

andrewballantyne approved these changes Mar 2, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2020

openshift-merge-robot merged commit b4ea75c into openshift:master Mar 3, 2020

openshift-cherrypick-robot mentioned this pull request Mar 3, 2020

[release-4.4] Bug 1809178: fixes issue with knative service in edit flow #4610

Merged

spadgett added this to the v4.5 milestone Mar 9, 2020

	imageStream?: FirehoseResult;
	imageStream?: FirehoseResult<K8sResourceKind[]>;

	const OrignalImageStreamTag = _.find(originalImageStream?.status?.tags, ['tag', tag]);
	const orignalImageStreamTag = _.find(originalImageStream?.status?.tags, ['tag', tag]);

	const orignalImageStreamTag = _.find(originalImageStream?.status?.tags, [
	const originalImageStreamTag = _.find(originalImageStream?.status?.tags, [

Bug 1807868: fixes issue with knative service in edit flow #4528

Bug 1807868: fixes issue with knative service in edit flow #4528

Conversation

invincibleJai commented Feb 27, 2020

openshift-ci-robot commented Feb 27, 2020

Choose a reason for hiding this comment

vikram-raj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

invincibleJai Mar 2, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewballantyne commented Mar 2, 2020

andrewballantyne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewballantyne left a comment

Choose a reason for hiding this comment

invincibleJai commented Mar 2, 2020

openshift-cherrypick-robot commented Mar 2, 2020

openshift-ci-robot commented Mar 2, 2020

andrewballantyne commented Mar 2, 2020

andrewballantyne commented Mar 2, 2020

openshift-bot commented Mar 2, 2020

openshift-bot commented Mar 2, 2020

openshift-bot commented Mar 2, 2020

christianvogt commented Mar 2, 2020

openshift-cherrypick-robot commented Mar 2, 2020

openshift-bot commented Mar 3, 2020

openshift-bot commented Mar 3, 2020

openshift-bot commented Mar 3, 2020

openshift-bot commented Mar 3, 2020

invincibleJai commented Mar 3, 2020 • edited

openshift-bot commented Mar 3, 2020

openshift-bot commented Mar 3, 2020

openshift-bot commented Mar 3, 2020

openshift-bot commented Mar 3, 2020

openshift-bot commented Mar 3, 2020

openshift-bot commented Mar 3, 2020

openshift-bot commented Mar 3, 2020

openshift-bot commented Mar 3, 2020

openshift-bot commented Mar 3, 2020

openshift-ci-robot commented Mar 3, 2020

openshift-cherrypick-robot commented Mar 3, 2020

invincibleJai Mar 2, 2020 •

edited

invincibleJai commented Mar 3, 2020 •

edited