New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1804447: Improve display of dashboard panels #4542
Bug 1804447: Improve display of dashboard panels #4542
Conversation
@sg00dwin: This pull request references Bugzilla bug 1804447, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@sg00dwin: This pull request references Bugzilla bug 1804447, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
e44e96a
to
cc58558
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/cherry-pick release-4.4 |
@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sg00dwin, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sg00dwin: All pull requests linked via external trackers have merged. Bugzilla bug 1804447 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@spadgett: #4542 failed to apply on top of branch "release-4.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#4534 has merged. Let's try again. /cherry-pick release-4.4 |
@spadgett: new pull request created: #4553 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This introduced a bug because there is no longer any padding below the graphs. That means the legends are not visible. |
Simple fix for legends: #4556 |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1804447
multiple issues addressed by switching to flexbox instead of bootstrap grid
Mobile width greater than phone landscape width, between 567px and 1199px
Left and right dashboard card edges now align with
monitoring-dashboards__header
elementsGreater than 1200