Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1804447: Improve display of dashboard panels #4542

Conversation

sg00dwin
Copy link
Member

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1804447
multiple issues addressed by switching to flexbox instead of bootstrap grid

  • Card height matches height of other cards in its row
  • Single stat cards can collapse to min content height, if needed
  • Loading state cards are same height as cards with content
  • K8s cluster single stat row switched single row of 6 to two rows of 3 cards, which alleviates card title overflow

Screen Shot 2020-02-27 at 12 30 07 PM

localhost_9000_monitoring_dashboards_grafana-dashboard-k8s-resources-cluster(1440x900 MBP 15_)


Mobile width greater than phone landscape width, between 567px and 1199px

  • allows for 2 column display
  • cards always expand to row width

Screen Shot 2020-02-27 at 11 49 56 AM

localhost_9000_monitoring_dashboards_grafana-dashboard-prometheus(1024x768 view)


Left and right dashboard card edges now align with monitoring-dashboards__header elements

Screen Shot 2020-02-27 at 2 31 57 PM


Greater than 1200

localhost_9000_monitoring_dashboards_grafana-dashboard-k8s-resources-cluster(1440x900 MBP 15_)

localhost_9000_monitoring_dashboards_grafana-dashboard-k8s-resources-cluster(1440x900 MBP 15_) (3)

localhost_9000_monitoring_dashboards_grafana-dashboard-k8s-resources-cluster(1440x900 MBP 15_) (2)

@openshift-ci-robot
Copy link
Contributor

@sg00dwin: This pull request references Bugzilla bug 1804447, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1804447: Improve display of dashboard panels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2020
@sg00dwin
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 27, 2020
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: This pull request references Bugzilla bug 1804447, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/monitoring Related to monitoring and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 27, 2020
@sg00dwin sg00dwin force-pushed the monitoring-dashboards-safari-card-wrap branch from e44e96a to cc58558 Compare February 27, 2020 21:55
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2020
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020
@spadgett
Copy link
Member

/cherry-pick release-4.4

@openshift-cherrypick-robot

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sg00dwin, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit fa54977 into openshift:master Feb 28, 2020
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: All pull requests linked via external trackers have merged. Bugzilla bug 1804447 has been moved to the MODIFIED state.

In response to this:

Bug 1804447: Improve display of dashboard panels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@spadgett: #4542 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	frontend/public/components/monitoring/_monitoring.scss
M	frontend/public/components/monitoring/dashboards/index.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/components/monitoring/dashboards/index.tsx
CONFLICT (content): Merge conflict in frontend/public/components/monitoring/dashboards/index.tsx
Auto-merging frontend/public/components/monitoring/_monitoring.scss
Patch failed at 0001 Bug 1804447: Enable better display of dashboard panels

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

#4534 has merged. Let's try again.

/cherry-pick release-4.4

@openshift-cherrypick-robot

@spadgett: new pull request created: #4553

In response to this:

#4534 has merged. Let's try again.

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyoto
Copy link
Member

kyoto commented Feb 28, 2020

This introduced a bug because there is no longer any padding below the graphs. That means the legends are not visible.

@kyoto
Copy link
Member

kyoto commented Feb 28, 2020

Simple fix for legends: #4556

@spadgett spadgett added this to the v4.5 milestone Feb 28, 2020
@sg00dwin sg00dwin deleted the monitoring-dashboards-safari-card-wrap branch June 15, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants