Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.4] Bug 1807293: Fix sort criteria for capacity on console #4544

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #4521

/assign jcaianirh

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1806875, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.5.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1806875 to depend on a bug targeting the "4.5.0" release and in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.4] Bug 1806875: Fix sort criteria for capacity on console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/core Related to console core functionality labels Feb 27, 2020
@jcaianirh jcaianirh changed the title [release-4.4] Bug 1806875: Fix sort criteria for capacity on console [release-4.4] Bug 1807293: Fix sort criteria for capacity on console Feb 27, 2020
@jcaianirh
Copy link
Member

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@jcaianirh: This pull request references Bugzilla bug 1807293, which is invalid:

  • expected dependent Bugzilla bug 1807294 to target the "4.5.0" release, but it targets "4.2.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaianirh
Copy link
Member

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 27, 2020
@openshift-ci-robot
Copy link
Contributor

@jcaianirh: This pull request references Bugzilla bug 1807293, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1806875 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1806875 targets the "4.5.0" release, matching the expected (4.5.0) release
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 27, 2020
@openshift openshift deleted a comment from openshift-ci-robot Feb 27, 2020
@jcaianirh
Copy link
Member

/test analyze

@jcaianirh
Copy link
Member

@bpeterson this is ready to merge to 4.4

@openshift openshift deleted a comment from openshift-ci-robot Feb 28, 2020
@benjaminapetersen
Copy link
Contributor

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020
@benjaminapetersen benjaminapetersen added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett spadgett added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit 85786a8 into openshift:release-4.4 Feb 28, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1807293 has been moved to the MODIFIED state.

In response to this:

[release-4.4] Bug 1807293: Fix sort criteria for capacity on console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console 469c780 link /test e2e-gcp-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcaianirh
Copy link
Member

/cherrypick release-4.3

@openshift-cherrypick-robot
Copy link
Author

@jcaianirh: #4544 failed to apply on top of branch "release-4.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	frontend/public/components/factory/table.tsx
M	frontend/public/components/persistent-volume-claim.jsx
M	frontend/public/components/persistent-volume.jsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/components/persistent-volume.jsx
Auto-merging frontend/public/components/persistent-volume-claim.jsx
Auto-merging frontend/public/components/factory/table.tsx
CONFLICT (content): Merge conflict in frontend/public/components/factory/table.tsx
Patch failed at 0001 Bug 1806875: Fix sort criteria for capacity on console

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants