Bug 1808394: remove default sorting from metrics table so query sort is prese… #4559
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
@rhamilto: This pull request references Bugzilla bug 1808394, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
openshift-ci-robot
added
the
approved
|
@rhamilto: This pull request references Bugzilla bug 1808394, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rhamilto
changed the title
|
/hold I don't think we should make this change. The issue isn't a bug, but an intentional design choice to allow sorting the results by any column. Perhaps we can find a better solution than the current behavior, but I don't think we should be removing the results sorting functionality because it is useful. Also, I think this is an RFE, rather than a bug fix. |
openshift-ci-robot
added
the
do-not-merge/hold
|
Do we have to disable sorting altogether? We could not sort by default, but let the user click column headers for a different sort. |
I disagree. Setting a default sort in the table is a bug. If the query includes sort and the resulting data doesn't reflect the query, that's a bug.
Good suggestion. Let me explore this. |
rhamilto
changed the title
rhamilto
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@rhamilto: This pull request references Bugzilla bug 1808394, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Updated to remove the default sort in the table, but still allow sorting via table headers. |
rhamilto
changed the title
|
/lgtm This solution looks good to me. Thanks @rhamilto! |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@rhamilto: All pull requests linked via external trackers have merged. Bugzilla bug 1808394 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@kyoto: new pull request created: #4594 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…rved
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1808394
Do not sort data by default so the results match the query. The use can still sort by column headers, however.
Before:
After:
[1]
