Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript 3.8.3 #4567

Merged
merged 1 commit into from Mar 10, 2020
Merged

TypeScript 3.8.3 #4567

merged 1 commit into from Mar 10, 2020

Conversation

spadgett
Copy link
Member

No description provided.

@spadgett spadgett added this to the v4.5 milestone Feb 29, 2020
@spadgett spadgett force-pushed the typescript-3.8.3 branch 4 times, most recently from 0ef4a4b to 3e37261 Compare February 29, 2020 17:33
@spadgett
Copy link
Member Author

spadgett commented Mar 1, 2020

/test

@spadgett
Copy link
Member Author

spadgett commented Mar 2, 2020

Closing and reopening to kick tests.

/close

@openshift-ci-robot
Copy link
Contributor

@spadgett: Closed this PR.

In response to this:

Closing and reopening to kick tests.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member Author

spadgett commented Mar 2, 2020

/reopen

@openshift-ci-robot
Copy link
Contributor

@spadgett: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 2, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: GitHub didn't allow me to assign the following users: ben.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @ben

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member Author

spadgett commented Mar 2, 2020

/assign @benjaminapetersen

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/dev-console Related to dev-console component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/monitoring Related to monitoring component/olm Related to OLM component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 2, 2020
@spadgett
Copy link
Member Author

spadgett commented Mar 2, 2020

/retest

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2020
@spadgett
Copy link
Member Author

spadgett commented Mar 9, 2020

Rebased

@spadgett spadgett added the area/dependency Issues or PRs related to dependency changes label Mar 9, 2020
@openshift-ci-robot openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Mar 9, 2020
benjaminapetersen
benjaminapetersen reviewed Mar 9, 2020
View reviewed changes
frontend/packages/console-shared/src/types/resource.ts Outdated
@@ -3,6 +3,10 @@ import { DEPLOYMENT_STRATEGY } from '../constants';
import { OverviewItemAlerts, PodControllerOverviewItem } from './pod';
import { ClusterServiceVersionKind } from '@console/operator-lifecycle-manager';

export type ErrorWithMessage = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering about a custom Error object type here, since it's not extending Error, is it right to call it an error?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slack note: maybe APIError.

benjaminapetersen
benjaminapetersen approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Nice, the types on useState seem like a win.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member Author

spadgett commented Mar 9, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

spadgett commented Mar 9, 2020

error An unexpected error occurred: "https://registry.yarnpkg.com/@patternfly/react-tokens/-/react-tokens-2.8.4.tgz: ESOCKETTIMEDOUT".

/retest

@spadgett
Copy link
Member Author

spadgett commented Mar 9, 2020

/hold
merge queue is broken

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2020
@spadgett
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2020
@spadgett
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e8d79fc into openshift:master Mar 10, 2020
@spadgett spadgett added kind/dependency-change Categorizes issue or PR as related to changing dependencies and removed area/dependency Issues or PRs related to dependency changes labels Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

Assignees

@benjaminapetersen benjaminapetersen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dev-console Related to dev-console component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/monitoring Related to monitoring component/olm Related to OLM component/shared Related to console-shared kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@spadgett @openshift-ci-robot @openshift-bot @benjaminapetersen @openshift-merge-robot