Bug 1795401: Improve monitoring dashboards performance #4569
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
@spadgett: This pull request references Bugzilla bug 1804922, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/invalid-bug
spadgett
force-pushed
the
dashboard-performance
branch
from
930e9b6
to
da2b347
Compare
spadgett
changed the title
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@spadgett: This pull request references Bugzilla bug 1795401, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/retest |
spadgett
changed the title
openshift-ci-robot
added
bugzilla/invalid-bug
|
@spadgett: This pull request references Bugzilla bug 1804922, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
spadgett
changed the title
openshift-ci-robot
added
bugzilla/valid-bug
|
@spadgett: This pull request references Bugzilla bug 1795401, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Switching the heavier stack graphs to line graphs looks OK to me. I'd prefer to not reduce the default samples though. It's already pretty low, especially for larger graph panels. |
|
FYI @cshinn |
spadgett
force-pushed
the
dashboard-performance
branch
from
da2b347
to
9f7b2a0
Compare
|
@spadgett: This pull request references Bugzilla bug 1795401, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I removed the default samples change |
|
/lgtm I think this is a fair trade-off for 4.4. We should be able to improve the performance over time and either remove or relax this restriction later, but this solves the immediate problem. Thanks @spadgett! |
|
/lgtm cancel One small suggestion before merging. |
| @@ -505,6 +508,9 @@ const QueryBrowser_: React.FC<QueryBrowserProps> = ({ | |||
|
|
|||
| const safeFetch = useSafeFetch(); | |||
|
|
|||
| const stack = | |||
| isStack && _.reduce(graphData, (total: number, { length }) => total + length, 0) <= maxStacks; | |||
There was a problem hiding this comment.
You could use _.sumBy(graphData, 'length')
Avoid stacked area charts when there are too many series.
spadgett
force-pushed
the
dashboard-performance
branch
from
9f7b2a0
to
06b3a63
Compare
openshift-ci-robot
added
size/XS
|
Thanks, updated |
|
/lgtm |
|
/cherry-pick release-4.4 |
|
@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@spadgett: All pull requests linked via external trackers have merged. Bugzilla bug 1795401 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@spadgett: new pull request created: #4589 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Avoid stacked area charts when there are too many series.
@kyoto Opinion on this change? The stacked area charts seem to be the ones with performance issues. Switching to a line chart when there are a lot of series makes a noticeable difference.