Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1793906: Align VM templates 'no project' page with VMs #4584

Merged
merged 1 commit into from Mar 4, 2020
Merged

Bug 1793906: Align VM templates 'no project' page with VMs #4584

merged 1 commit into from Mar 4, 2020

Conversation

pcbailey
Copy link
Contributor

@pcbailey pcbailey commented Mar 2, 2020

This PR aligns the template used for the VM template list page when no project has been created to that used by the VM list page.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 2, 2020
@openshift-ci-robot
Copy link
Contributor

@pcbailey: This pull request references Bugzilla bug 1793906, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1793906: Align VM templates 'no project' page with VMs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/kubevirt Related to kubevirt-plugin labels Mar 2, 2020
@pcbailey pcbailey force-pushed the fix-vm-template-no-projects-bug branch from 665d2bc to 0086a27 Compare March 2, 2020 13:07
@jelkosz
Copy link

jelkosz commented Mar 3, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 3, 2020
@openshift-ci-robot
Copy link
Contributor

@jelkosz: This pull request references Bugzilla bug 1793906, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 3, 2020
@jelkosz
Copy link

jelkosz commented Mar 3, 2020

/test frontend

@pcbailey pcbailey force-pushed the fix-vm-template-no-projects-bug branch from 0086a27 to da395be Compare March 3, 2020 13:24
@pcbailey pcbailey force-pushed the fix-vm-template-no-projects-bug branch from da395be to 80fb4df Compare March 3, 2020 14:02
@rawagner
Copy link
Contributor

rawagner commented Mar 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2020
@jelkosz
Copy link

jelkosz commented Mar 3, 2020

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@pcbailey
Copy link
Contributor Author

pcbailey commented Mar 3, 2020

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jelkosz
Copy link

jelkosz commented Mar 4, 2020

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8b389f4 into openshift:master Mar 4, 2020
@openshift-ci-robot
Copy link
Contributor

@pcbailey: All pull requests linked via external trackers have merged. Bugzilla bug 1793906 has been moved to the MODIFIED state.

In response to this:

Bug 1793906: Align VM templates 'no project' page with VMs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pcbailey
Copy link
Contributor Author

pcbailey commented Mar 4, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 4, 2020
Merged
@openshift-cherrypick-robot
Copy link

@pcbailey: new pull request created: #4636

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone Mar 9, 2020
@pcbailey pcbailey deleted the fix-vm-template-no-projects-bug branch October 26, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawagner rawagner rawagner left review comments

@mareklibra mareklibra Awaiting requested review from mareklibra

@vojtechszocs vojtechszocs Awaiting requested review from vojtechszocs

Assignees

@rawagner rawagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pcbailey @openshift-ci-robot @jelkosz @rawagner @openshift-bot @openshift-cherrypick-robot @spadgett @openshift-merge-robot