Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1809813: Handle object references with missing API version #4617

Merged
merged 1 commit into from Mar 17, 2020
Merged

Bug 1809813: Handle object references with missing API version #4617

merged 1 commit into from Mar 17, 2020

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Mar 3, 2020

apiVersion is optional in some object references such as involvedObject on events. Fall back to modelFor to locate the model from the kind when it's missing.

/assign @rhamilto

Before:

Screenshot_2020-03-03 Events · Red Hat OpenShift Container Platform

After:

Screenshot_2020-03-03 Events · OKD(1)

@spadgett spadgett added this to the v4.5 milestone Mar 3, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 3, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Bugzilla bug 1809813, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1809813: Handle object references with missing API version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 3, 2020
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 3, 2020
@spadgett
Copy link
Member Author

spadgett commented Mar 3, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto
Copy link
Member

rhamilto commented Mar 4, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2020
@rhamilto
Copy link
Member

rhamilto commented Mar 4, 2020

/retest

@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Mar 4, 2020 •
edited 

 Summary of all failing tests
FAIL packages/container-security/src/__tests__/kebab-actions.spec.ts
  ● Test suite failed to run
    TypeError: k8s_1.referenceForModel is not a function

Appears something is broken?

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

spadgett commented Mar 5, 2020

/lgtm cancel
unit test failures

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2020
@spadgett
Bug 1809813: Handle object references with missing API version
8b2840f 
`apiVersion` is optional in some object references such as
`involvedObject` on events. Fall back to `modelFor` to locate the model
from the kind when it's missing.
benjaminapetersen
benjaminapetersen approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d74ef4c into openshift:master Mar 17, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: All pull requests linked via external trackers have merged. Bugzilla bug 1809813 has been moved to the MODIFIED state.

In response to this:

Bug 1809813: Handle object references with missing API version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 17, 2020
Closed
@openshift-cherrypick-robot
Copy link

@spadgett: new pull request created: #4753

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett deleted the event-api-version branch April 23, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

@kyoto kyoto Awaiting requested review from kyoto

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@benjaminapetersen benjaminapetersen

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@spadgett @openshift-ci-robot @openshift-cherrypick-robot @rhamilto @benjaminapetersen @openshift-bot @openshift-merge-robot