Bug 1810002: Fix Prometheus query on VMI utilization graphs #4623
Conversation
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @danielBelenky. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/S
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
danielBelenky
changed the title
|
@danielBelenky: This pull request references Bugzilla bug 1810002, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@rawagner: This pull request references Bugzilla bug 1810002, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
FYI @openshift/openshift-team-monitoring |
| @@ -10,28 +10,29 @@ export enum VMQueries { | |||
| } | |||
|
|
|||
| const queries = { | |||
| // We don't set namespace explicitly in the PromQL template because it is | |||
| // being injected anyway by prom-label-proxy when we query Thanos. | |||
There was a problem hiding this comment.
fwiw you could potentially still leave it here for clarity, although being a no-op.
There was a problem hiding this comment.
I don't mind adding it, but I think that it causes confusion where you specify the namespace in the query and it doesn't really being used... especially in cases where there will be a conflict between what is rendered here and what is present in the query param...
|
@danielBelenky please fix the linting issues - frontend tests are failing. |
We should not specify the namespace label on the PromQL query because it is being overwritten anyway by prom-query-proxy to whatever we set in the namespace query param. Signed-off-by: Daniel Belenky <dbelenky@redhat.com>
danielBelenky
force-pushed
the
fix-vmi-utilization
branch
from
507ae4a
to
a363680
Compare
Done 👍 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielBelenky, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/cherry-pick release-4.4 |
|
@rawagner: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@danielBelenky: All pull requests linked via external trackers have merged. Bugzilla bug 1810002 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@rawagner: new pull request created: #4664 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We should not specify the namespace label on the PromQL query because it
is being overwritten anyway by prom-query-proxy to whatever we set in
the namespace query param.
** Related PR on KubeVirt **: (ensures that the labels on our metrics are honored)
kubevirt/kubevirt#3125
Signed-off-by: Daniel Belenky dbelenky@redhat.com