Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.4] Bug 1808062: Silenced alerts should not show up in the Notification Drawer of the console #4635

Merged
merged 1 commit into from Mar 6, 2020
Merged

[release-4.4] Bug 1808062: Silenced alerts should not show up in the Notification Drawer of the console #4635

merged 1 commit into from Mar 6, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #4538

/assign dtaylor113

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 4, 2020
Merged
@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 4, 2020
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Mar 4, 2020
@dtaylor113 dtaylor113 changed the title [release-4.4] Bug 1808059: Silenced alerts should not show up in the Notification Drawer of the console [release-4.4] Bug 1808062: Silenced alerts should not show up in the Notification Drawer of the console Mar 4, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 4, 2020
@openshift-ci-robot
Copy link
Contributor

@dtaylor113: This pull request references Bugzilla bug 1808062, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1808059 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1808059 targets the "4.5.0" release, matching the expected (4.5.0) release
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift openshift deleted a comment from openshift-ci-robot Mar 4, 2020
@openshift openshift deleted a comment from openshift-ci-robot Mar 4, 2020
@openshift openshift deleted a comment from openshift-ci-robot Mar 4, 2020
@dtaylor113 dtaylor113 requested review from benjaminapetersen, spadgett and rhamilto and removed request for benjaminapetersen March 4, 2020 20:05
@benjaminapetersen
Copy link
Contributor

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benjaminapetersen benjaminapetersen added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett spadgett added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 6, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4cdb943 into openshift:release-4.4 Mar 6, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1808062 has been moved to the MODIFIED state.

In response to this:

[release-4.4] Bug 1808062: Silenced alerts should not show up in the Notification Drawer of the console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@zherman0 zherman0 Awaiting requested review from zherman0

@spadgett spadgett Awaiting requested review from spadgett

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@benjaminapetersen benjaminapetersen

@dtaylor113 dtaylor113

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @benjaminapetersen @openshift-bot @spadgett @dtaylor113 @openshift-merge-robot