Bug 1810642: Snapshot feature for is part of 4.5v #4655

a2batic · 2020-03-05T12:43:06Z

Moves snapshot feature to 4.5 for OCS.

afreen23 · 2020-03-05T14:36:18Z

On small PRs, one gets picky.

Moves snapshot feature to 4.5 for OCP.

This is for OCS 4.5

bipuladh

I think it would be better if we parse 4.4 take the 4 and guard the value to be > 4. That way we will have lower bound guards rather than having guard for every version.

a2batic · 2020-03-05T16:27:10Z

/retitle Bug 1810642: Snapshot feature for is part of 4.5v

openshift-ci-robot · 2020-03-05T16:27:18Z

@a2batic: This pull request references Bugzilla bug 1810642, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1810642: Snapshot feature for is part of 4.5v

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23 · 2020-03-06T02:09:59Z

frontend/packages/ceph-storage-plugin/src/features.ts

  const version = subscription?.status?.currentCSV;
-  return version && version.includes('ocs-operator.v4.4');
+  return version && version.includes('ocs-operator.v4.5');


Something like this maybe:
version.split('.')[2] >= 5

afreen23 · 2020-03-06T02:13:38Z

frontend/packages/ceph-storage-plugin/src/features.ts

@@ -19,19 +19,19 @@ export const detectIndependentMode: ActionFeatureFlagDetector = (dispatch) =>
    },
  );

-export const OCS_VERSION_4_4_FLAG = 'OCS_VERSION_4_4';
+export const OCS_VERSION_4_5_FLAG = 'OCS_VERSION_4_5';


Suggested change

export const OCS_VERSION_4_5_FLAG = 'OCS_VERSION_4_5';

export const OCS_4_5_AND_ABOVE_FLAG = 'OCS_4_5_AND_ABOVE';

bipuladh · 2020-03-06T09:45:32Z

/lgtm

a2batic · 2020-03-06T09:46:27Z

/cherry-pick release 4.4

openshift-cherrypick-robot · 2020-03-06T09:46:28Z

@a2batic: once the present PR merges, I will cherry-pick it on top of release 4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release 4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

a2batic · 2020-03-06T11:40:22Z

/test e2e-gcp-console

a2batic · 2020-03-06T17:18:42Z

/test e2e-gcp-console

bipuladh

Minor changes

bipuladh · 2020-03-06T17:41:06Z

frontend/packages/ceph-storage-plugin/src/features.ts

@@ -20,19 +20,20 @@ export const detectIndependentMode: ActionFeatureFlagDetector = (dispatch) =>
    },
  );

-export const OCS_VERSION_4_4_FLAG = 'OCS_VERSION_4_4';
+export const OCS_VERSION_4_5_AND_ABOVE_FLAG = 'OCS_VERSION_4_5_AND_ABOVE_FLAG';


If you look at the flag name the value does not have flag in it.

We are detecting 4_5. No need for the above part.

bipuladh · 2020-03-06T19:03:27Z

/lgtm

openshift-ci-robot · 2020-03-06T19:03:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a2batic, bipuladh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/ceph-storage-plugin/OWNERS~~ [bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-03-06T22:03:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-06T22:55:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-03-07T02:18:33Z

@a2batic: All pull requests linked via external trackers have merged. Bugzilla bug 1810642 has been moved to the MODIFIED state.

In response to this:

Bug 1810642: Snapshot feature for is part of 4.5v

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-03-07T02:18:42Z

@a2batic: cannot checkout release 4.4: error checking out release 4.4: exit status 1. output: error: pathspec 'release 4.4' did not match any file(s) known to git.

In response to this:

/cherry-pick release 4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

a2batic · 2020-03-09T06:21:19Z

/cherry-pick release-4.4

openshift-cherrypick-robot · 2020-03-09T06:21:34Z

@a2batic: new pull request created: #4689

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/ceph Related to ceph-storage-plugin labels Mar 5, 2020

openshift-ci-robot requested review from bipuladh and rawagner March 5, 2020 12:45

bipuladh reviewed Mar 5, 2020

View reviewed changes

openshift-ci-robot changed the title ~~Bug: Snapshot feature for is part of 4.5v~~ Bug 1810642: Snapshot feature for is part of 4.5v Mar 5, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 5, 2020

afreen23 reviewed Mar 6, 2020

View reviewed changes

a2batic force-pushed the feature-snapshot branch 2 times, most recently from 7a500d1 to a23ebd7 Compare March 6, 2020 09:39

openshift-ci-robot assigned bipuladh Mar 6, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 6, 2020

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2020

a2batic force-pushed the feature-snapshot branch from a23ebd7 to 9fad83a Compare March 6, 2020 17:00

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 6, 2020

bipuladh reviewed Mar 6, 2020

View reviewed changes

Bug 1810642: Snapshot feature for is part of 4.5v

bf31b8a

a2batic force-pushed the feature-snapshot branch from 9fad83a to bf31b8a Compare March 6, 2020 19:01

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2020

openshift-merge-robot merged commit a2affee into openshift:master Mar 7, 2020

openshift-cherrypick-robot mentioned this pull request Mar 9, 2020

[release-4.4] Bug 1811545: Snapshot feature for is part of 4.5v #4689

Merged

spadgett added this to the v4.5 milestone Mar 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1810642: Snapshot feature for is part of 4.5v #4655

Bug 1810642: Snapshot feature for is part of 4.5v #4655

a2batic commented Mar 5, 2020 •

edited

afreen23 commented Mar 5, 2020

bipuladh left a comment

a2batic commented Mar 5, 2020

openshift-ci-robot commented Mar 5, 2020

afreen23 Mar 6, 2020

afreen23 Mar 6, 2020

bipuladh commented Mar 6, 2020

a2batic commented Mar 6, 2020

openshift-cherrypick-robot commented Mar 6, 2020

a2batic commented Mar 6, 2020

a2batic commented Mar 6, 2020

bipuladh left a comment

bipuladh Mar 6, 2020

bipuladh Mar 6, 2020

a2batic Mar 6, 2020

bipuladh commented Mar 6, 2020

openshift-ci-robot commented Mar 6, 2020

openshift-bot commented Mar 6, 2020

openshift-bot commented Mar 6, 2020

openshift-ci-robot commented Mar 7, 2020

openshift-cherrypick-robot commented Mar 7, 2020

a2batic commented Mar 9, 2020

openshift-cherrypick-robot commented Mar 9, 2020

	export const OCS_VERSION_4_5_FLAG = 'OCS_VERSION_4_5';
	export const OCS_4_5_AND_ABOVE_FLAG = 'OCS_4_5_AND_ABOVE';

Bug 1810642: Snapshot feature for is part of 4.5v #4655

Bug 1810642: Snapshot feature for is part of 4.5v #4655

Conversation

a2batic commented Mar 5, 2020 • edited

afreen23 commented Mar 5, 2020

bipuladh left a comment

Choose a reason for hiding this comment

a2batic commented Mar 5, 2020

openshift-ci-robot commented Mar 5, 2020

afreen23 Mar 6, 2020

Choose a reason for hiding this comment

afreen23 Mar 6, 2020

Choose a reason for hiding this comment

bipuladh commented Mar 6, 2020

a2batic commented Mar 6, 2020

openshift-cherrypick-robot commented Mar 6, 2020

a2batic commented Mar 6, 2020

a2batic commented Mar 6, 2020

bipuladh left a comment

Choose a reason for hiding this comment

bipuladh Mar 6, 2020

Choose a reason for hiding this comment

bipuladh Mar 6, 2020

Choose a reason for hiding this comment

a2batic Mar 6, 2020

Choose a reason for hiding this comment

bipuladh commented Mar 6, 2020

openshift-ci-robot commented Mar 6, 2020

openshift-bot commented Mar 6, 2020

openshift-bot commented Mar 6, 2020

openshift-ci-robot commented Mar 7, 2020

openshift-cherrypick-robot commented Mar 7, 2020

a2batic commented Mar 9, 2020

openshift-cherrypick-robot commented Mar 9, 2020

a2batic commented Mar 5, 2020 •

edited