Bug 1810601: auto focus on the topology filter component to avoid confusion #4658
Conversation
|
@jeff-phillips-18: This pull request references Bugzilla bug 1810601, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
openshift-ci-robot
added
component/core
|
@jeff-phillips-18: This pull request references Bugzilla bug 1810601, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18, karthikjeeyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@jeff-phillips-18 I don't observe this issue on 4.5 CI build 4.5.0-0.ci-2020-03-05-134327. Is it addressed already? |
|
No, this has not yet been addressed in 4.5. |
|
@jeff-phillips-18: All pull requests linked via external trackers have merged. Bugzilla bug 1810601 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jeff-phillips-18: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.4 |
|
@invincibleJai: new pull request created: #4670 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-3254
Analysis / Root cause:
When navigating to the topology page no component gets focus. Clicking on nodes does not get focus so clicking on a link then leaves focus on the nav. When navigating away, the focus is still on the 'Topology' so it appears to still be selected. Also, if the user then hits the enter key, they will be navigated back to Topology.
Solution Description:
Focus on the filter component upon entry of the topology view. This is consistent with the Operator Hub view and Add from Catalog view.
Browser conformance:
/kind bug