New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.4] Bug 1810745: Fix jest config to run olm unit tests and disable failing tests #4669
[release-4.4] Bug 1810745: Fix jest config to run olm unit tests and disable failing tests #4669
Conversation
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1810726, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1810745, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@TheRealJon: This pull request references Bugzilla bug 1810745, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
cherry pick approved since this is test code only changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
Confirmed 99% fixes to stale tests to re-enable them since they stopped running when OLM was broken out into a separate package. One small noop optimization change.
I think we have much less risk knowing these tests are running around this section of the app.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1810745 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #4666
/assign TheRealJon