Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1810568: set panel state to hidden after animation and when drawer is closed #4686

Closed
wants to merge 1 commit into from
Closed

Bug 1810568: set panel state to hidden after animation and when drawer is closed #4686

wants to merge 1 commit into from

Conversation

jcaianirh
Copy link
Member

@jcaianirh jcaianirh commented Mar 7, 2020 •
edited

@openshift-ci-robot
Copy link
Contributor

@jcaianirh: This pull request references Bugzilla bug 1810568, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1810568: set panel state to hidden after animation and when drawer is closed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 7, 2020
@openshift-ci-robot
Copy link
Contributor

@jcaianirh: This pull request references Bugzilla bug 1810568, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1810568: set panel state to hidden after animation and when drawer is closed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Mar 7, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcaianirh
To complete the pull request process, please assign christianvogt
You can assign the PR to them by writing /assign @christianvogt in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcaianirh
Copy link
Member Author

/test e2e-gcp-console

@spadgett
Copy link
Member

spadgett commented Mar 9, 2020

Hey @jcaianirh I'd rather wait for an upstream fix to be honest. Setting the drawer hidden immediately means the animation doesn't happen? That sounds like a PF bug.

@jcaianirh
Copy link
Member Author

jcaianirh commented Mar 9, 2020 •
edited

@spadgett sounds good. I created the issue in pf. We can wait for that fix I just created this in case we wanted an interim solution.

spadgett
spadgett reviewed Mar 9, 2020
View reviewed changes
frontend/public/components/notification-drawer.tsx
@@ -288,7 +312,8 @@ export const ConnectedNotificationDrawer_: React.FC<ConnectedNotificationDrawerP
<NotificationDrawer
className="co-notification-drawer"
isInline={isDesktop}
isExpanded={isDrawerExpanded}
isExpanded={isDrawerExpanded && !isDrawerAnimating}
isDrawerHidden={isDrawerHidden}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused... There are separate isExpanded and isDrawerHidden props? What is the difference between those?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spadgett Yea, so this will go away when the actual component fix is completed, but the idea is that the panel component is set to hidden when it finishes animation so the focus doesn't expose the closed panel. When the drawer is fixed, this can be removed.

@benjaminapetersen
Copy link
Contributor

/hold
For upstream fix (just to make it explicit per above conversation).

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2020
@jcaianirh
Copy link
Member Author

closing this in favor of css only fix here: #5577

@openshift-ci-robot openshift-ci-robot mentioned this pull request May 28, 2020
Merged
@spadgett spadgett closed this Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett left review comments

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees
No one assigned
Labels
bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcaianirh @openshift-ci-robot @spadgett @benjaminapetersen