New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1812139: List oc as first cli #4717
Bug 1812139: List oc as first cli #4717
Conversation
@rebeccaalpert: This pull request references Bugzilla bug 1812139, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @spadgett |
Looks like a test needs an update here, we have a selector flake.
Since we have to update anyway (probably a race on render), might be good to confirm that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
I can circle back around for the lgtm
when the tests are 👍 . Thanks!
/cherry-pick release-4.4 This is low risk, and a bit of a branding quirk we may want to be corrected. |
@benjaminapetersen: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pushed the new test. The OLM test issue seems to be a flake - it's running well locally. |
6add0e3
to
7baa945
Compare
Reordered data so oc would be the first cli on the cli page. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1812139
Addressed PR feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, rebeccaalpert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@rebeccaalpert: All pull requests linked via external trackers have merged. Bugzilla bug 1812139 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@benjaminapetersen: new pull request created: #4796 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reordered data so oc would be the first cli on the cli page.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1812139.