Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1812139: List oc as first cli #4717

Merged
merged 1 commit into from Mar 23, 2020

Conversation

rebeccaalpert
Copy link
Contributor

Reordered data so oc would be the first cli on the cli page.

Screen Shot 2020-03-11 at 4 56 58 PM

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1812139.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 11, 2020
@openshift-ci-robot
Copy link
Contributor

@rebeccaalpert: This pull request references Bugzilla bug 1812139, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1812139: List oc as first cli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 11, 2020
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Mar 11, 2020
@rebeccaalpert
Copy link
Contributor Author

/assign @spadgett

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2020
@benjaminapetersen benjaminapetersen self-assigned this Mar 12, 2020
@benjaminapetersen
Copy link
Contributor

Looks like a test needs an update here, we have a selector flake.

StaleElementReferenceError: stale element reference: element is not attached to the page document

Since we have to update anyway (probably a race on render), might be good to confirm that the cli downloads are the first item.

Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I can circle back around for the lgtm when the tests are 👍 . Thanks!

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2020
@benjaminapetersen
Copy link
Contributor

/cherry-pick release-4.4

This is low risk, and a bit of a branding quirk we may want to be corrected.

@openshift-cherrypick-robot

@benjaminapetersen: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

This is low risk, and a bit of a branding quirk we may want to be corrected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rebeccaalpert
Copy link
Contributor Author

Pushed the new test. The OLM test issue seems to be a flake - it's running well locally.

Reordered data so oc would be the first cli on the cli page.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1812139
@rebeccaalpert
Copy link
Contributor Author

Addressed PR feedback.

Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, rebeccaalpert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rebeccaalpert
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 7a1e32a into openshift:master Mar 23, 2020
@openshift-ci-robot
Copy link
Contributor

@rebeccaalpert: All pull requests linked via external trackers have merged. Bugzilla bug 1812139 has been moved to the MODIFIED state.

In response to this:

Bug 1812139: List oc as first cli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@benjaminapetersen: new pull request created: #4796

In response to this:

/cherry-pick release-4.4

This is low risk, and a bit of a branding quirk we may want to be corrected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants