Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Browser: Replace tooltip datum prop with datumX and datumY #4747

Merged
merged 1 commit into from Mar 17, 2020
Merged

Query Browser: Replace tooltip datum prop with datumX and datumY #4747

merged 1 commit into from Mar 17, 2020

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Mar 17, 2020

The datum prop would change every time the mouse pointer moved,
causing the tooltip to re-render. We only need to re-render the tooltip
when the highlighted data point (datumX and datumY) changes.

@kyoto
Query Browser: Replace tooltip datum prop with datumX and datumY
cb6de35 
The `datum` prop would change every time the mouse pointer moved,
causing the tooltip to re-render. We only need to re-render the tooltip
when the highlighted data point (`datumX` and `datumY`) changes.
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/monitoring Related to monitoring approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 17, 2020
spadgett
spadgett approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0a43cfc into openshift:master Mar 17, 2020
@kyoto kyoto deleted the query-browser-tooltip-datum-prop branch March 18, 2020 02:34
@spadgett spadgett added this to the v4.5 milestone Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kyoto @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot