Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1809812: Fix catalog overflow on mobile #4751

Merged
merged 1 commit into from Mar 18, 2020
Merged

Bug 1809812: Fix catalog overflow on mobile #4751

merged 1 commit into from Mar 18, 2020

Conversation

rebeccaalpert
Copy link
Contributor

Added property to hide overflow on offending section of catalog.

Screen Shot 2020-03-17 at 12 03 47 PM

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1809812.

@rebeccaalpert
Bug 1809812: Fix catalog overflow on mobile
05755b4 
Added property to hide overflow on offending section of catalog.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1809812
@openshift-ci-robot
Copy link
Contributor

@rebeccaalpert: This pull request references Bugzilla bug 1809812, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1809812: Fix catalog overflow on mobile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality labels Mar 17, 2020
@rebeccaalpert
Copy link
Contributor Author

Test flake unrelated to CSS change:

Failed Specs:
1) Kubernetes resource CRUD operations Pod : search view displays created resource instance
   TimeoutError: Wait timed out after 10005ms

/retest

dtaylor113
dtaylor113 approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rhamilto
rhamilto approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, rebeccaalpert, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ec8f982 into openshift:master Mar 18, 2020
@openshift-ci-robot
Copy link
Contributor

@rebeccaalpert: All pull requests linked via external trackers have merged. Bugzilla bug 1809812 has been moved to the MODIFIED state.

In response to this:

Bug 1809812: Fix catalog overflow on mobile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@dtaylor113 dtaylor113 dtaylor113 approved these changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rebeccaalpert @openshift-ci-robot @openshift-bot @rhamilto @dtaylor113 @spadgett @openshift-merge-robot