Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring: Always show Severity field on details pages #4771

Merged
merged 1 commit into from Mar 20, 2020
Merged

Monitoring: Always show Severity field on details pages #4771

merged 1 commit into from Mar 20, 2020

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Mar 19, 2020 •
edited

Always show the Severity field on the alert details page and alerting
rule details page.

If no severity is found, show - with no icon, but this should not
happen since all our alerts specify a severity.

FYI @cshinn

@kyoto
Monitoring: Always show Severity field on details pages
ec48f7d 
Always show the Severity field on the alert details page and alerting
rule details page.

If no severity is found, show `-` with no icon, but this should not
happen since all our alerts specify a `severity`.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2020
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Mar 19, 2020
@kyoto
Copy link
Member Author

kyoto commented Mar 19, 2020

/retest

1 similar comment
@kyoto
Copy link
Member Author

kyoto commented Mar 19, 2020

/retest

spadgett
spadgett approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett spadgett added this to the v4.5 milestone Mar 19, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 179a279 into openshift:master Mar 20, 2020
@kyoto kyoto deleted the monitoring-always-show-severity branch March 20, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kyoto @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot