adds associated deployment and pods in sidebar for event sources #4779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
invincibleJai
force-pushed
the
feat-sidebar-evsrc
branch
from
f6cd041
to
39a47fd
Compare
serenamarie125
approved these changes
Mar 20, 2020
| expect(findSidebarSectionHeading.at(1).props().text).toEqual('Deployment'); | ||
| }); | ||
|
|
||
| it('should not show pods if not present', () => { |
There was a problem hiding this comment.
Test does have pods. Wrong name?
There was a problem hiding this comment.
Yes , have updated
| const sink = _.get(obj, 'spec.sink.ref') || _.get(obj, 'spec.sink'); | ||
| const sinkUri = _.get(obj, 'status.sinkUri', null); | ||
| const namespace = _.get(obj, 'metadata.namespace', null); | ||
| const deploymentData = _.get(current, 'obj.metadata.ownerReferences[0]', {}); |
There was a problem hiding this comment.
Let's move away from using lodash get.
invincibleJai
force-pushed
the
feat-sidebar-evsrc
branch
from
39a47fd
to
0ab1aac
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, invincibleJai, serenamarie125 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://issues.redhat.com/browse/ODC-3006
Analysis / Root cause:
Currently, Event Sources sidebar just show knative serving it's syncing to and it should show associated deployments/pods if any.
Solution Description:
Event Sources sidebar will list knative serving it's syncing to and associated deployments/pods if any.
Screen shots / Gifs for design review:
Unit test coverage report:
Browser conformance:
cc @serenamarie125 @openshift/team-devconsole-ux