Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring: Split silenced alert counts by severity and info icon #4786

Merged
merged 1 commit into from Mar 26, 2020
Merged

Monitoring: Split silenced alert counts by severity and info icon #4786

merged 1 commit into from Mar 26, 2020

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Mar 23, 2020

On Silences list page, split the "Firing Alerts" counts (number of
silenced alerts) by alert severity.
Make "Firing Alerts" the second column in the Silences list.
Add icon for alerts severity info.

Info Icon

screenshot

Silences List

screenshot-1

@kyoto
Monitoring: Split silenced alert counts by severity and info icon
9c3f87d 
On Silences list page, split the "Firing Alerts" counts (number of
silenced alerts) by alert severity.
Make "Firing Alerts" the second column in the Silences list.
Add icon for alerts severity `info`.
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 23, 2020
@kyoto
Copy link
Member Author

kyoto commented Mar 23, 2020

/retest

@kyoto
Copy link
Member Author

kyoto commented Mar 23, 2020

FYI @cshinn

@kyoto
Copy link
Member Author

kyoto commented Mar 26, 2020

/retest

spadgett
spadgett approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 373f0d8 into openshift:master Mar 26, 2020
@openshift-ci-robot
Copy link
Contributor

@kyoto: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console 9c3f87d link /test e2e-gcp-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyoto kyoto deleted the monitoring-alert-severity-count branch March 27, 2020 01:39
@spadgett spadgett added this to the v4.5 milestone Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kyoto @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot