Move VMTemplates view into Virtualization section #4800
Conversation
openshift-ci-robot
added
component/kubevirt
|
/test analyze |
|
/assign @pcbailey |
| import { FLAGS } from '@console/shared'; | ||
| import { connectToFlags, FlagsObject } from '@console/internal/reducers/features'; | ||
| import { compose } from 'redux'; |
There was a problem hiding this comment.
nitpick: I think the redux import should come before the console imports and the two console imports should be moved to be with the other console imports above.
| match={props.match} | ||
| obj={obj} | ||
| customData={{ showTitle: false }} | ||
| {...props} |
There was a problem hiding this comment.
nitpick: I think the convention is to put the props spread at the top of the props list.
|
/lgtm |
| import { connectToFlags, FlagsObject } from '@console/internal/reducers/features'; | ||
| import { FLAGS } from '@console/shared'; | ||
| import { HorizontalNav } from '@console/internal/components/utils'; | ||
| import { withStartGuide } from '@console/internal/components/start-guide'; |
There was a problem hiding this comment.
I think it should be:
import { withStartGuide } from '@console/internal/components/start-guide';
import { HorizontalNav } from '@console/internal/components/utils';
import { connectToFlags, FlagsObject } from '@console/internal/reducers/features';
import { FLAGS } from '@console/shared';
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-gcp-console |
2 similar comments
|
/test e2e-gcp-console |
|
/test e2e-gcp-console |
CNV4006 - Move VMTemplates view into Virtualization section
Screenshot:
