Add E2E tests for Installation flow #4803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
component/ceph
gnehapk
reviewed
Mar 24, 2020
frontend/packages/ceph-storage-plugin/integration-tests/tests/ocp-tests/installFlow.scenario.ts
Show resolved
Hide resolved
gnehapk
reviewed
Mar 24, 2020
frontend/packages/ceph-storage-plugin/integration-tests/tests/ocp-tests/installFlow.scenario.ts
Outdated
Show resolved
Hide resolved
gnehapk
reviewed
Mar 24, 2020
bipuladh
force-pushed
the
install_test_ocp
branch
from
c390689
to
de836be
Compare
gnehapk
reviewed
Mar 26, 2020
frontend/packages/ceph-storage-plugin/integration-tests/tests/ocp-tests/installFlow.scenario.ts
Outdated
Show resolved
Hide resolved
umangachapagain
suggested changes
Mar 26, 2020
frontend/packages/ceph-storage-plugin/integration-tests/tests/ocp-tests/installFlow.scenario.ts
Outdated
Show resolved
Hide resolved
|
|
||
| const Installer = new InstallCluster(NS); | ||
|
|
||
| describe('Testing OCS Cluster Creation', () => { |
There was a problem hiding this comment.
Suggested change
| describe('Testing OCS Cluster Creation', () => { | |
| describe('Testing OpenShift Container Storage Installation, () => { |
There was a problem hiding this comment.
We are testing cluster creation there are e2e-tests for operators-hub that test installation of an operator.
frontend/packages/ceph-storage-plugin/integration-tests/tests/ocp-tests/installFlow.scenario.ts
Outdated
Show resolved
Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/tests/ocp-tests/installFlow.scenario.ts
Outdated
Show resolved
Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/tests/ocp-tests/installFlow.scenario.ts
Outdated
Show resolved
Hide resolved
bipuladh
force-pushed
the
install_test_ocp
branch
from
de836be
to
9096996
Compare
|
/retest |
1 similar comment
|
/retest |
bipuladh
force-pushed
the
install_test_ocp
branch
from
9096996
to
bbbea01
Compare
|
/retest |
gnehapk
reviewed
Mar 27, 2020
| export const hasOCSTaint = (node) => { | ||
| const taints = node?.spec?.taints || []; | ||
| return taints.some((taint) => _.isEqual(taint, ocsTaint)); | ||
| }; |
There was a problem hiding this comment.
Why you have defined the functions again here? You can reuse the function from node-list.tsx
There was a problem hiding this comment.
You can't pull that code into e2e tests and vice versa,
|
/retest |
bipuladh
force-pushed
the
install_test_ocp
branch
2 times, most recently
from
fc03bca
to
c2542c6
Compare
|
/retest |
bipuladh
force-pushed
the
install_test_ocp
branch
from
c2542c6
to
cfcf303
Compare
|
/approve |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
bipuladh
force-pushed
the
install_test_ocp
branch
from
cfcf303
to
0fbc4a1
Compare
|
/approve |
umangachapagain
approved these changes
Apr 3, 2020
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, gnehapk, umangachapagain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are targetted to run on OCP CI (e2e-gcp-console)