Optional initial template for create vm wizard #4811

yaacov · 2020-03-24T19:49:45Z

Set initial template for create vm wizard

a - move name and description inputs to top of form.
b - add optional initial template to the vm wizard.
c - adjust links to the virtualization path.
d - add create vm link to the vm-template list.

Design: openshift/openshift-origin-design#350

Screenshot:

yaacov · 2020-03-24T19:50:49Z

@suomiy @glekner please revierw

/assigne @suomiy

yaacov · 2020-03-24T19:54:01Z

/assign @suomiy

yaacov · 2020-03-24T20:07:11Z

/test e2e-gcp-console
/test images

yaacov · 2020-03-25T07:02:11Z

/test e2e-gcp-console

yaacov · 2020-03-25T08:40:08Z

/test e2e-gcp-console

yaacov · 2020-03-25T09:51:56Z

@yfrimanm @matthewcarleton please review

yaacov · 2020-03-25T10:08:50Z

/test e2e-gcp-console
/test analyze

yaacov · 2020-03-25T10:11:56Z

/test e2e-gcp-console

yaacov · 2020-03-25T10:25:04Z

/test e2e-gcp-console

atiratree · 2020-03-25T11:03:55Z

frontend/packages/kubevirt-plugin/src/components/vm-templates/vm-template.tsx

+const getCreateLink = (
+  namespace: string,
+  itemName: 'yaml' | 'wizard' = 'wizard',
+  mode: 'template' | 'vm' = 'template',


can we make an enum of that?

atiratree · 2020-03-25T11:04:41Z

frontend/packages/kubevirt-plugin/src/components/vm-templates/vm-template.tsx

    ],
    tableColumnClasses,
  );

 VMTemplateTableHeader.displayName = 'VMTemplateTableHeader';

+const getCreateLink = (
+  namespace: string,
+  itemName: 'yaml' | 'wizard' = 'wizard',


and from that?

atiratree · 2020-03-25T11:09:28Z

frontend/packages/kubevirt-plugin/src/components/create-vm-wizard/create-vm-wizard.tsx

@@ -576,6 +576,9 @@ export const CreateVMWizardPageComponent: React.FC<CreateVMWizardPageComponentPr
    );
  }

+  const userMode = new URLSearchParams(search).get('mode');


variable can be extracted here

atiratree · 2020-03-25T11:09:51Z

frontend/packages/kubevirt-plugin/src/components/create-vm-wizard/create-vm-wizard.tsx

@@ -584,8 +587,9 @@ export const CreateVMWizardPageComponent: React.FC<CreateVMWizardPageComponentPr
  return (
    <Firehose resources={resources} doNotConnectToState>
      <CreateVMWizard
-        isCreateTemplate={!path.includes('/virtualmachines/')}
-        isProviderImport={new URLSearchParams(search).get('mode') === 'import'}
+        isCreateTemplate={userMode === 'template'}


we can use this enum here

atiratree · 2020-03-25T11:12:09Z

frontend/packages/kubevirt-plugin/src/components/vm-templates/vm-template.tsx

    ],
    tableColumnClasses,
  );

 VMTemplateTableHeader.displayName = 'VMTemplateTableHeader';

+const getCreateLink = (


can you please make a reusable funtion which includes also import and basic vm.

Basically this funtion + createLink from vm.tsx + enums for all the stuff

it could live probably under constants?

atiratree · 2020-03-25T11:13:41Z

frontend/packages/kubevirt-plugin/src/components/vm-templates/vm-template.tsx

+  namespace: string,
+  itemName: 'yaml' | 'wizard' = 'wizard',
+  mode: 'template' | 'vm' = 'template',
+  template?: string,


probably better to have one object as parameters

atiratree · 2020-03-25T11:14:35Z

...-plugin/src/components/create-vm-wizard/redux/initial-state/vm-settings-tab-initial-state.ts

-  [VMSettingsField.WORKLOAD_PROFILE]: 9,
-  [VMSettingsField.NAME]: 10,
-  [VMSettingsField.DESCRIPTION]: 11,
+  [VMSettingsField.NAME]: 0,


name returns to the the top again! :)

atiratree · 2020-03-25T11:22:54Z

...src/components/create-vm-wizard/redux/stateUpdate/vmSettings/vm-settings-tab-state-update.ts

+
+  if (
+    iGetCommonData(state, id, VMWizardProps.isCreateTemplate) ||
+    iGetVmSettingAttribute(state, id, VMSettingsField.USER_TEMPLATE, 'initialized')


we should set the initialized property according to the VMWizardProps.userTemplateName and VMWizardProps.isCreateTemplate in vm-settings-tab-initial-state.ts

so we would not need this check here VMWizardProps.isCreateTemplate

plus this should also break when there was no change to the templates

about the initial state - shouldn't we set the value of template in the beggining so the user sees it? and maybe disable it for good for this wizard instance?

about the initial state - shouldn't we set the value of template in the beggining so the user sees it? and maybe disable it for good for this wizard instance?

done 🍰

🎂 🎉 fixed

atiratree · 2020-03-25T11:24:21Z

frontend/packages/kubevirt-plugin/src/components/create-vm-wizard/create-vm-wizard.tsx

@@ -576,6 +576,9 @@ export const CreateVMWizardPageComponent: React.FC<CreateVMWizardPageComponentPr
    );
  }

+  const userMode = new URLSearchParams(search).get('mode');
+  const userTemplateName = new URLSearchParams(search).get('template');


we should make a null of this if the mode is something different than the template

atiratree · 2020-03-25T11:29:38Z

frontend/packages/kubevirt-plugin/src/components/vm-templates/vm-template.tsx

@@ -54,6 +55,7 @@ const tableColumnClasses = [
  tableColumnClassHiddenOnSmall,
  tableColumnClassHiddenOnSmall,
  tableColumnClassHiddenOnSmall,
+  tableColumnClass,


thses should be max 12 together

matthewcarleton · 2020-03-25T16:23:20Z

@yaacov I'm not sure we want to allow them to switch the template in this flow do we?
When the work that @yfrimanm is finishing up comes in we'll have the "select template" as the first step in the wizard so if they really want to go back and choose a different one they can.
Providing it in a dropdown doesn't give them much info on the template so it's really not that helpful.

yaacov · 2020-03-25T16:26:48Z

@yaacov I'm not sure we want to allow them to switch the template in this flow do we?

@matthewcarleton 👍
It's locked, will update the screen shot ...

yaacov · 2020-03-25T16:33:44Z

@matthewcarleton I've updated the screen-shot in the description.
It shows the disabled template drop-down.

atiratree · 2020-03-25T17:32:26Z

frontend/packages/kubevirt-plugin/src/components/create-vm-wizard/types.ts

@@ -40,6 +41,18 @@ export enum VMWizardProps {

 export const ALL_VM_WIZARD_TABS = getStringEnumValues<VMWizardTab>(VMWizardTab);

+export enum VMWizardName {


these enums are the interface - they should be probably in ./src/constants

atiratree · 2020-03-25T17:34:21Z

frontend/packages/kubevirt-plugin/src/components/create-vm-wizard/create-vm-wizard.tsx

@@ -576,6 +577,10 @@ export const CreateVMWizardPageComponent: React.FC<CreateVMWizardPageComponentPr
    );
  }

+  const searchParams = new URLSearchParams(search);
+  const userMode = searchParams.get('mode');
+  const userTemplateName = userMode === VMWizardMode.VM ? searchParams.get('template') || '' : '';


Suggested change

const userTemplateName = userMode === VMWizardMode.VM ? searchParams.get('template') || '' : '';

const userTemplateName = userMode === VMWizardMode.VM && searchParams.get('template') || '';

atiratree · 2020-03-25T17:37:39Z

...-plugin/src/components/create-vm-wizard/redux/initial-state/vm-settings-tab-initial-state.ts

@@ -44,6 +44,8 @@ export const getInitialVmSettings = (data: CommonData): VMSettings => {
    [VMSettingsField.DESCRIPTION]: {},
    [VMSettingsField.USER_TEMPLATE]: {
      isHidden: hiddenByProviderOrTemplate,
+      initialized: isProviderImport || isCreateTemplate || !userTemplateName,


isn't this better?

Suggested change

initialized: isProviderImport || isCreateTemplate || !userTemplateName,

initialized: !(isCreateTemplate && userTemplateName),

we don't need to check the other cases

atiratree · 2020-03-25T17:39:10Z

...src/components/create-vm-wizard/redux/stateUpdate/vmSettings/vm-settings-tab-state-update.ts

+  const { id, dispatch, getState } = options;
+  const state = getState();
+
+  if (iGetVmSettingAttribute(state, id, VMSettingsField.USER_TEMPLATE, 'initialized')) {


please proceed also only if options.changedCommonData.has(VMWizardProps.userTemplates)

can you please use changedCommonData - it is more clear indicator and one can see the function prerequisites in the beginning of the function

atiratree · 2020-03-25T17:48:05Z

...src/components/create-vm-wizard/redux/stateUpdate/vmSettings/vm-settings-tab-state-update.ts

+    vmWizardInternalActions[InternalActionType.UpdateVmSettings](id, {
+      [VMSettingsField.USER_TEMPLATE]: {
+        initialized: true,
+        value: userTemplateName,


value is already set

although I worry a bit that it might cause bugs in the future if somebody is listening only on the string value

lets leave it for now

atiratree · 2020-03-25T18:00:21Z

...ages/kubevirt-plugin/src/components/create-vm-wizard/tabs/vm-settings-tab/user-templates.tsx

+      />
+    );
+
+    const optionsList = sortedNames.map((name) => (


no good reason to have this extracted IMO

right ! fixed

atiratree · 2020-03-25T18:06:42Z

...ages/kubevirt-plugin/src/components/create-vm-wizard/tabs/vm-settings-tab/user-templates.tsx

-  ({ userTemplateField, userTemplates, commonTemplates, onChange, openshiftFlag }) => {
+  ({
+    userTemplateField,
+    userTemplateName,


it is very confusing to read a variable like this in this context.
Can we rename it here?

like: forceSingleUserTemplateName ?

atiratree · 2020-03-25T18:09:46Z

frontend/packages/kubevirt-plugin/src/components/vms/vm.tsx

@@ -163,19 +165,7 @@ const getCreateProps = ({ namespace }: { namespace: string }) => {



you can also use the constants to create the object keys above

atiratree · 2020-03-25T18:11:38Z

frontend/packages/kubevirt-plugin/src/utils/utils.ts

@@ -51,3 +52,20 @@ export const getVMLikeModelDetailPath = (
  namespace: string,
  name: string,
 ) => `${getVMLikeModelListPath(isCreateTemplate, namespace)}/${name}`;
+
+export const getVMWizardCreateLink = (


can this live rather in ./url.ts or ./endpoints.ts or something like that

utils/utils.ts should only for the most random stuff we can't place anywhere else

atiratree · 2020-03-25T18:19:20Z

frontend/packages/kubevirt-plugin/src/utils/utils.ts

+  const wizardMode = itemName === VMWizardName.IMPORT ? VMWizardMode.IMPORT : mode;
+
+  const type = itemName === VMWizardName.YAML ? '~new' : '~new-wizard';
+  const args = `${wizardMode ? `mode=${wizardMode}` : ''}${


can we use URLSearchParams here? as it is less prone to mistakes

yaacov · 2020-03-26T16:06:30Z

/test frontend

yaacov · 2020-03-26T16:07:31Z

/test analyze
/test frontend
/test backend

yaacov · 2020-03-26T16:09:02Z

/test analyze
/test frontend
/test backend

yaacov · 2020-03-26T16:24:39Z

/test analyze
/test frontend
/test backend

yaacov · 2020-03-26T16:33:51Z

/test analyze
/test frontend
/test backend

yaacov · 2020-03-26T16:49:41Z

/test analyze
/test frontend
/test backend

yaacov · 2020-03-26T17:02:33Z

/test analyze
/test frontend
/test backend

yaacov · 2020-03-26T17:02:52Z

ci/prow/e2e-gcp-console

atiratree · 2020-03-26T17:15:06Z

...src/components/create-vm-wizard/redux/stateUpdate/vmSettings/vm-settings-tab-state-update.ts

+
+  const userTemplates = iGetLoadedCommonData(state, id, VMWizardProps.userTemplates);
+  if (!userTemplates) {
+    return;


no need for this return

atiratree · 2020-03-26T17:17:12Z

...src/components/create-vm-wizard/redux/stateUpdate/vmSettings/vm-settings-tab-state-update.ts

+export const selectUserTemplateOnLoadedUpdater = (options: UpdateOptions) => {
+  const { id, dispatch, getState } = options;
+  const state = getState();
+  if (options.changedCommonData.has(VMWizardProps.userTemplates)) {


how would this even work?

if user templates changed do not do anything

please look at the other updaters for examples on how these guards should work

atiratree · 2020-03-26T17:20:02Z

...evirt-plugin/src/components/create-vm-wizard/redux/validations/vm-settings-tab-validation.ts

  const userTemplate = iGetLoadedCommonData(state, id, VMWizardProps.userTemplates, List()).find(
    (template) => iGetName(template) === userTemplateName,
  );

+  if (!userTemplate) {
+    return asValidationObject(
+      'Template is missing, check template name',


maybe we should ask somebody from UX to have a better message :)

it is not that the template name is wrong - it is just the template is missing for unknown reason (probably got deleted right now)

change to be less instructive :-)

atiratree · 2020-03-26T17:21:19Z

...ages/kubevirt-plugin/src/components/create-vm-wizard/tabs/vm-settings-tab/user-templates.tsx

+
+    const optionsList = !forceSingleUserTemplateName && hasUserTemplates && (
+      <>
+        {optionNoTemplate}


can we inline the variable here?

nice, I like it 👍

atiratree · 2020-03-26T17:27:24Z

frontend/packages/kubevirt-plugin/src/utils/url.ts

+    params.append('template', template);
+  }
+
+  return `/k8s/ns/${namespace || 'default'}/virtualization/${type}${params ? `?${params}` : ''}`; // covers 'yaml', new-wizard and default


the params is an object here so it is always true - we should first make it a string and then do the comparison for appending "?...."

atiratree · 2020-03-26T18:00:29Z

...evirt-plugin/src/components/create-vm-wizard/redux/validations/vm-settings-tab-validation.ts

@@ -88,7 +88,7 @@ const validateUserTemplate: VmSettingsValidator = (field, options) => {

  if (!userTemplate) {
    return asValidationObject(
-      'Template is missing, check template name',
+      "Can't verify tempalte, template is missing",


:-) thanks !

atiratree · 2020-03-26T18:02:21Z

...src/components/create-vm-wizard/redux/stateUpdate/vmSettings/vm-settings-tab-state-update.ts

@@ -35,10 +35,6 @@ export const selectUserTemplateOnLoadedUpdater = (options: UpdateOptions) => {
  }

  const userTemplateName = iGetCommonData(state, id, VMWizardProps.userTemplateName);
-  if (!userTemplateName) {


wrong return removed ^^ this return is quite useful.

🤦‍♂️ :-)

atiratree · 2020-03-26T18:03:54Z

...src/components/create-vm-wizard/redux/stateUpdate/vmSettings/vm-settings-tab-state-update.ts

@@ -26,7 +26,7 @@ import { prefillVmTemplateUpdater } from './prefill-vm-template-state-update';
 export const selectUserTemplateOnLoadedUpdater = (options: UpdateOptions) => {
  const { id, dispatch, getState } = options;
  const state = getState();
-  if (options.changedCommonData.has(VMWizardProps.userTemplates)) {
+  if (!options.changedCommonData.has(VMWizardProps.userTemplates)) {


can we check for the initialized first? As this updater will be checked only few seconds after opening and for the rest of life of the wizard the initialized prop should be enough

atiratree · 2020-03-26T18:20:22Z

/lgtm

openshift-ci-robot · 2020-03-26T18:20:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suomiy, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/kubevirt-plugin/OWNERS~~ [suomiy,yaacov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

atiratree · 2020-04-06T13:24:05Z

Btw, shouldn't we have the Create Virtual Machine option in the template detail as well, in the actions kebab? Shouldn't we also move this action into the template list kebab for consistency as well?

@yaacov @yfrimanm @matthewcarleton

matthewcarleton · 2020-04-06T14:35:28Z

Btw, shouldn't we have the Create Virtual Machine option in the template detail as well, in the actions kebab? Shouldn't we also move this action into the template list kebab for consistency as well?

@yaacov @yfrimanm @matthewcarleton

+1 it was in the design :)

yfrimanm · 2020-04-06T14:56:08Z

Yes, it's part of the design. Please see the attached. Thanks.

…

On Mon, Apr 6, 2020 at 5:35 PM matthew carleton ***@***.***> wrote: Btw, shouldn't we have the Create Virtual Machine option in the template detail as well, in the actions kebab? Shouldn't we also move this action into the template list kebab for consistency as well? @yaacov <https://github.com/yaacov> @yfrimanm <https://github.com/yfrimanm> @matthewcarleton <https://github.com/matthewcarleton> +1 it was in the design :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4811 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKUDFDDLE5DAPX53U4L5YXDRLHSEFANCNFSM4LS6ET3A> .

yaacov · 2020-04-06T15:01:32Z

shouldn't we have the Create Virtual Machine option in the template detail as well,

+1 it was in the design :)

@yfrimanm @matthewcarleton hi, thanks for the feedback, are you sure we have a design for chanes in the template detail page, I'm looking at this design[1] what am I missing ?

[1] http://openshift.github.io/openshift-origin-design/designs/virtualization/4.x/Templates/Templates.html

matthewcarleton · 2020-04-06T15:11:28Z

ah ya I'm looking at the list view kebab for the "create virtual machine" and it's not there and should be according to the design.

Looking at the design we don't specifically show the template design although I'd assume the actions from that view would be the same as the actions from the list view of the templates right?

It looks like maybe the confusion came from the inline action for creating a vm from the template in the list view.

yaacov · 2020-04-06T16:14:09Z

@matthewcarleton the design suggest two options [1]:
a - A link (button) to "create vm".
b - Adds a "create vm" action to the drop down.

If we want to add both action and link (button), we will need to update the design.

[1] http://openshift.github.io/openshift-origin-design/designs/virtualization/4.x/Templates/Templates.html#virtual-machine-templates-tab

matthewcarleton · 2020-04-06T16:25:08Z

sorry for the confusion @yaacov
When I initially read this line in the design:

From the Virtualization left nav item the user goes to the Virtual machine templates tab where they can see the full list of templates. From this point, we suggest 2 options to create a VM

I took it as both options are included and the user can choose either to create a VM. I think what happened was with the second design I didn't notice the action was gone b/c the kebab menu covered it.
I agree we need to update the design to make it more clear. @yfrimanm Do you mind putting up a new PR to do this?

atiratree · 2020-04-06T16:33:23Z

IMO we should have at least kebab option in both places, so that the user can expect the same behavior in the list and in the detail.

matthewcarleton · 2020-04-06T16:59:14Z

IMO we should have at least kebab option in both places, so that the user can expect the same behavior in the list and in the detail.

agreed

openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Mar 24, 2020

openshift-ci-robot requested review from mareklibra and rhrazdil March 24, 2020 19:50

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020

openshift-ci-robot assigned atiratree Mar 24, 2020

yaacov changed the title ~~kubevirt: set init template for vm wizard~~ Optional initial template for create vm wizard Mar 25, 2020

yaacov force-pushed the vm-wizard-move-name-and-description-to-top branch 3 times, most recently from 5d45e66 to 10edf2e Compare March 25, 2020 05:42

yaacov force-pushed the vm-wizard-move-name-and-description-to-top branch 2 times, most recently from 095a114 to b678e44 Compare March 25, 2020 08:13

yaacov force-pushed the vm-wizard-move-name-and-description-to-top branch 2 times, most recently from 836f63d to 1419d14 Compare March 25, 2020 09:39

atiratree suggested changes Mar 25, 2020

View reviewed changes

yaacov mentioned this pull request Mar 25, 2020

kubevirt: add ImportProvider tab and WizardErrors component #4814

Merged

1 task

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2020

atiratree suggested changes Mar 25, 2020

View reviewed changes

yaacov force-pushed the vm-wizard-move-name-and-description-to-top branch from f59741b to e09bbd0 Compare March 25, 2020 18:21

atiratree reviewed Mar 26, 2020

View reviewed changes

yaacov added 2 commits March 26, 2020 19:50

fix xviii

491b80c

fix xix

b798b44

atiratree reviewed Mar 26, 2020

View reviewed changes

yaacov added 2 commits March 26, 2020 20:09

last fix (really)

14a2256

last fix (really really)

24af3bd

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2020

openshift-merge-robot merged commit 71a4851 into openshift:master Mar 26, 2020

yaacov mentioned this pull request Mar 26, 2020

kubevirt: Don't show error message before templates are loaded #4835

Merged

spadgett added this to the v4.5 milestone Mar 31, 2020

yaacov mentioned this pull request Apr 7, 2020

Add create vm dropdown action #4937

Merged

		@@ -40,6 +41,18 @@ export enum VMWizardProps {

		export const ALL_VM_WIZARD_TABS = getStringEnumValues<VMWizardTab>(VMWizardTab);

		export enum VMWizardName {

	const userTemplateName = userMode === VMWizardMode.VM ? searchParams.get('template') \|\| '' : '';
	const userTemplateName = userMode === VMWizardMode.VM && searchParams.get('template') \|\| '';

	initialized: isProviderImport \|\| isCreateTemplate \|\| !userTemplateName,
	initialized: !(isCreateTemplate && userTemplateName),

		@@ -163,19 +165,7 @@ const getCreateProps = ({ namespace }: { namespace: string }) => {

Optional initial template for create vm wizard #4811

Optional initial template for create vm wizard #4811

Conversation

yaacov commented Mar 24, 2020 • edited

yaacov commented Mar 24, 2020

yaacov commented Mar 24, 2020

yaacov commented Mar 24, 2020

yaacov commented Mar 25, 2020

yaacov commented Mar 25, 2020

yaacov commented Mar 25, 2020

yaacov commented Mar 25, 2020

yaacov commented Mar 25, 2020

yaacov commented Mar 25, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matthewcarleton commented Mar 25, 2020

yaacov commented Mar 25, 2020

yaacov commented Mar 25, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yaacov commented Mar 26, 2020

yaacov commented Mar 26, 2020

yaacov commented Mar 26, 2020

yaacov commented Mar 26, 2020

yaacov commented Mar 26, 2020

yaacov commented Mar 26, 2020

yaacov commented Mar 26, 2020

yaacov commented Mar 26, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atiratree commented Mar 26, 2020

openshift-ci-robot commented Mar 26, 2020

atiratree commented Apr 6, 2020

matthewcarleton commented Apr 6, 2020

yfrimanm commented Apr 6, 2020 via email

yaacov commented Mar 24, 2020 •

edited

matthewcarleton commented Apr 6, 2020 •

edited