Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1794118: Removed asterisk style from description #4812

Merged
merged 1 commit into from Mar 26, 2020
Merged

Bug 1794118: Removed asterisk style from description #4812

merged 1 commit into from Mar 26, 2020

Conversation

gnehapk
Copy link
Contributor

@gnehapk gnehapk commented Mar 25, 2020 •
edited

removed-asterisk

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2020
@gnehapk
Copy link
Contributor Author

gnehapk commented Mar 25, 2020

/assign @afreen23

bipuladh
bipuladh reviewed Mar 25, 2020
View reviewed changes
frontend/packages/ceph-storage-plugin/src/components/ocs-install/create-form.tsx Outdated
@@ -34,7 +34,7 @@ export const CreateOCSServiceForm: React.FC<CreateOCSServiceFormProps> = ({
title="A bucket will be created to provide the OCS Service."
isInline
/>
<p className="co-legend co-required ceph-ocs-desc__legend">
<p className="co-legend co-required ceph-ocs-co-required">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we use 'co-required'..?

Copy link
Contributor Author

@gnehapk gnehapk Mar 26, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

co-required style is already used. See it carefully. Few css styles have been overwritten by ceph-ocs-co-required as the co-required styles is written with assumption of single line text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single line text assumption fits everywhere except this page.

afreen23
afreen23 reviewed Mar 26, 2020
View reviewed changes
frontend/packages/ceph-storage-plugin/src/components/ocs-install/create-form.tsx
@@ -34,7 +34,7 @@ export const CreateOCSServiceForm: React.FC<CreateOCSServiceFormProps> = ({
title="A bucket will be created to provide the OCS Service."
isInline
/>
<p className="co-legend co-required ceph-ocs-desc__legend">
<p className="co-legend co-required ceph-ocs-co-required">
Select at least 3 nodes in different failure domains with minimum requirements of 16 CPUs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally co-required should be on Select Nodes since thats the form field, the rest is info text.

console/frontend/packages/ceph-storage-plugin/src/components/ocs-install/create-form.tsx

Lines 23 to 25 in ae4892f

<Title headingLevel="h5" size="lg" className="ceph-install-select-node__title">
Select Nodes
</Title>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its as per the UXD.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since most of the required form field dont have this css, lets remove it.
Thanks!

afreen23
afreen23 reviewed Mar 26, 2020
View reviewed changes
frontend/packages/ceph-storage-plugin/src/components/ocs-install/ocs-install.scss Outdated

.ceph-ocs-co-required::after {
top: auto;
bottom: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bottom: 0 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since, the text expanded to 2 lines, hence bottom:0 will work. Feel free to try it out.

@gnehapk gnehapk changed the title Fixed asterisk style for description Removed asterisk style from description Mar 26, 2020
@afreen23
Copy link
Contributor

/retest

@afreen23
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, gnehapk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gnehapk
Copy link
Contributor Author

gnehapk commented Mar 26, 2020

/test e2e-gcp-console

@gnehapk gnehapk mentioned this pull request Mar 26, 2020
Closed
@gnehapk gnehapk changed the title Removed asterisk style from description Bug 1794118: Removed asterisk style from description Mar 26, 2020
@openshift-ci-robot
Copy link
Contributor

@gnehapk: This pull request references Bugzilla bug 1794118, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1794118: Removed asterisk style from description

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 26, 2020
@gnehapk
Copy link
Contributor Author

gnehapk commented Mar 26, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 26, 2020
@openshift-ci-robot
Copy link
Contributor

@gnehapk: This pull request references Bugzilla bug 1794118, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnehapk
Copy link
Contributor Author

gnehapk commented Mar 26, 2020

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit be639ca into openshift:master Mar 26, 2020
@openshift-ci-robot
Copy link
Contributor

@gnehapk: All pull requests linked via external trackers have merged: openshift/console#4710, openshift/console#4812. Bugzilla bug 1794118 has been moved to the MODIFIED state.

In response to this:

Bug 1794118: Removed asterisk style from description

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnehapk
Copy link
Contributor Author

gnehapk commented Mar 27, 2020

/retest

@gnehapk gnehapk mentioned this pull request Mar 27, 2020
Merged
@spadgett spadgett added this to the v4.5 milestone Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afreen23 afreen23 afreen23 left review comments

@bipuladh bipuladh bipuladh left review comments

@rawagner rawagner Awaiting requested review from rawagner

Assignees

@afreen23 afreen23

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gnehapk @afreen23 @openshift-ci-robot @openshift-bot @bipuladh @spadgett @openshift-merge-robot